Add an ESM compatible build to grunt script via Rollup #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 28, 2023 16:44
This does not change the `dist` command's current outputs
|
Looks like the changes broke expectations for existing checks. Please have a look! @NiloCK |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return carry ? (carry.toString() + sum) : sum; | ||
| } | ||
| function testZero(number) { | ||
| return (/^0[0]*[.]{0,1}[0]*$/.test(number)); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
royNiladri
added a commit
that referenced
this pull request
Aug 2, 2023
* Bugfix #84 fixed buggy round * 1.3.11 * 1.3.12 * bugfix #63: fix addition of -0 * build files * 1.3.13 * added devcontainer * changed gulpfile for macos * added feature 'abs' #83 * 1.3.14 * added abs to readme * 1.3.15 * semantic dependency updates * Add feature for #32 setValue * 1.4.0 * Merge branch 'master' of https://github.com/royNiladri/js-big-decimal into development * upadted packagelock * 1.4.1 * Add an ESM compatible build to grunt script via Rollup (#99) * add rollup dev dependencies * change export mechanism... This does not change the `dist` command's current outputs * add rollup es module bundling to grunt dist task * Fix typo * add "module" esm target file * add built esm outputs * fixed tests for esm * 2.0.0 --------- Co-authored-by: Niladri Roy <niroy@informatica.com> Co-authored-by: Colin Kennedy <NiloCK@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98.
This PR makes js-big-decimal easier to import in (at least some) current build / bundle pipelines. See related thread vitejs/vite#13031 for more context.
npm run distnow produces anesmfolder, andpackage.jsonpoints to its output with itsmodulesfield. Existing build steps are intact -npm run distreproduces the previousnodeandwebfolders.Build has been tested with a canary publish to https://www.npmjs.com/package/js-big-decimal-esm - importing this module resolves the issue between vite & js-big-decimal.