Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torch jinet implementation #196

Merged
merged 40 commits into from Sep 26, 2022
Merged

Conversation

AhmetCanSolak
Copy link
Collaborator

This PR aims to implement jinet in torch and eventually replace the existing cnn-jinet denoiser implementation.

@AhmetCanSolak AhmetCanSolak self-assigned this Jun 15, 2022
@AhmetCanSolak AhmetCanSolak marked this pull request as ready for review July 21, 2022 22:50
Copy link
Collaborator

@li-li-github li-li-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if tests pass!

aydin/nn/models/torch/torch_jinet.py Show resolved Hide resolved
aydin/nn/models/torch/torch_jinet.py Show resolved Hide resolved
writer.close()


# def n2s_jinet_train_loop():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this implementation also going to be included in the current PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be a separate one as it needs more testing

@AhmetCanSolak AhmetCanSolak merged commit 7e39b03 into royerlab:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants