Don't set _IS_INIT = true before initializing _ALGO_INSTANCE #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails because of changes in rustc. Fixed by #17. |
I hope I don't miss any subtle detail, but it looks wrong to set _IS_INIT before _ALGO_INSTANCE gets initialized. In case new returns Err, _ALGO_INSTANCE will stay uninitialized, but a later call to UnInit will still try to drop it. As there is already a _IS_INIT = true immediately after setting _ALGO_INSTANCE, I think this line can just be removed.
thejpster
force-pushed
the
fix-init-bookkeeping
branch
from
9f98290
to
b70c16e
Compare
|
Rebased on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I don't miss any subtle detail, but it looks wrong to set _IS_INIT before _ALGO_INSTANCE gets initialized. In case new returns Err, _ALGO_INSTANCE will stay uninitialized, but a later call to UnInit will still try to drop it.
As there is already a _IS_INIT = true immediately after setting _ALGO_INSTANCE, I think this line can just be removed.