Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now builds on stable. #18

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Now builds on stable. #18

merged 3 commits into from
Dec 12, 2023

Conversation

thejpster
Copy link
Member

@thejpster thejpster commented Dec 8, 2023 •
edited
Loading

Tested working with probe-rs CLI. Slightly larger binary, but I can live with that for not having to use nightly rust.

$ ./build.sh
    Finished release [optimized + debuginfo] target(s) in 0.10s
    instructions: 8LUDr4mwK0x8RCB4ASgqTX1EKk5+RAPRKGiARzBogEcBIAiQIHAGlRglKogHlBQkIIgFlhtOMUb3MZBHBJAqiCCIGUmJHJBHA5AqiCCIMUaQRwKQKoggiBRJkEcBkCqIIIgTSZBHBkYqiCCIDkmQRwVGBJygRwOYgEcRSHhEApkBYBBIeEQEYA9IeEQBmQFgBpgGYAWYBWAImAeZCHAAIAmw8L1SRQAAQ1gAAFJQAABGQwAAeAEAAIABAACAAQAADAEAAAABAAACAQAA0LUCrwhMfEQgeAEoCtEHSHhEAGiARwZIeEQAaIBHACAgcNC9ASDQva4AAAC0AAAAsAAAAAVIeEQAeAAoAdEBIHBHAUhwR8BG0HAAAH4AAADQtQKvCUl5RAl4ASkM0Q8hCQdAGAZJeUQMaAEiEQMSBNgjoEcAINC9ASDQvV4AAABWAAAA0LUCrwtGCUl5RAl4ASkK0Q8hCQdAGAZJeUQMaBFGGkagRwAg0L0BINC9wEYoAAAAJAAAAADU1NQAAAAAAAAAAAAAAAAAAAAAAAAAAA==
    pc_init: 1
    pc_uninit: 205
    pc_program_page: 337
    pc_erase_sector: 285
    pc_erase_all: 257

It also uses the official ROM function for walking the ROM table entries rather than walking them manually.

@thejpster
Now builds on stable.
d8b90c0 
Tested working with probe-rs CLI. Slightly larger binary, but I can live with that for not having to use nightly rust.
@thejpster thejpster requested a review from jannic December 8, 2023 21:18
jannic
jannic reviewed Dec 8, 2023
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@thejpster
Fail if ROM funcs are missing.
35fd979 
Belt-and-braces in case we ever get a different RP2040 ROM with missing functions.

Also use constants for the ROM addresses.
@thejpster
Add docs so clippy is happy.
1d215be
@thejpster thejpster mentioned this pull request Dec 9, 2023
Merged
@thejpster thejpster merged commit 0c2ac40 into main Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannic jannic jannic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thejpster @jannic