Implement Channel<Adc> for DynPin

[jannic]

No description provided.

[ithinuel]

Could we have an enum there?

Something simple like

#[cfg_attr(feature = "defmt", derive(defmt::Defmt))]
#[derive(Debug, Copy, Clone, PartialEq, Eq)]
pub struct InvalidPinError;

and return Err(nb::Error::Other(InvalidPinError)).

(The exact error's name may be different.)

[jannic]

Good point. I copied that type from impl<WORD, PIN> OneShot<Adc, WORD, PIN> for Adc. But there, something like InvalidPinError can't happen. In fact, that implementation never returns Err. I wonder why it has type Error = () and not type Error = Infallible. But that's a different topic, and changing that would be a breaking change.

[jannic]

I didn't include all those derives on purpose:

• we don't do it on the other error types in this crate
• I think we should strive for consistently
• adding derives is easier than removing them, as it doesn't break existing code

[jannic]

Changed to draft as it probably conflicts with #585

[jannic]

Obsoleted by #585