unpkg/edat: Extract and check for edat on the correct directory #10891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd add a bool var before the switch statement, then each content type can specify if it needs to append title ID or not because I suspect this will be a revisted topic in the future. |
|
Then the concatenation can just be inside the switch cases as needed in the future IMO, it's likely other cases don't need it as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #10581
After checking on console, it appears the unpkg code has been incorrect. It's very likely that other content types also do not need the title ID to be appended, needs further investigation. For now, this hotfixes the previous assumption.