Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Texturing improvements #11163

Merged
merged 9 commits into from Nov 24, 2021
Merged

rsx: Texturing improvements #11163

merged 9 commits into from Nov 24, 2021

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Nov 16, 2021

  • Remember to update format class when doing mipmap gather in case of cross-aspect respec.
  • Fix handling of 16-bit formats in blit engine. The logical representation of RGB565 is very different than R16U when interpolation is enabled.

Fixes #10875
Fixes #9076

@Megamouse Megamouse added the RSX label Nov 16, 2021
@Crafty-The-Fox
Copy link

Crafty-The-Fox commented Nov 16, 2021

This fixes the "wireframe like" issue. but I'm not sure if this was hiding behind it. Parts of the models start to disappear when the game goes farther and farther from the camera. In the 1st screenshot some of the crowd is red instead of the assumed green, and textures next to the deck are scrambled. Those issues are minor though.
image

In the second screenshot you can also see some clipping with the models happening
image

In the 3rd screenshot, it looks normal. This is probably because the camera is closer to the crowd.
image

I compared the 2nd image to the screenshots from console that @shockdude posted in the issue, so it seems to be a RPCS3 issue.

RSX Captures: https://mega.nz/folder/PKomkYpR#ppy0b8FWhHyTEhrIEhhrnw

@shockdude
Copy link
Contributor

I can replicate @Crafty-The-Fox's first image.
In the lower-right, in front of that funny structure, a woman's head is invisible despite being visible in master. Also the dancers in the PR are red when they should be green.

PR 11163
Log: RPCS3_pr11163.log.gz
RSX Capture: https://drive.google.com/file/d/1JPl71-AzL9I7djGnGXKJOZnwJ1_JMlOt/view?usp=sharing
BLUS30526_screenshot_2021_11_16_pr11163

Master 0.0.19-13024
Log: RPCS3_master13024.log.gz
RSX Capture: https://drive.google.com/file/d/1-0-coPzVp68qJNqHLQleR14cfZAz2b2G/view?usp=sharing
BLUS30526_screenshot_2021_11_16_master13024

Console
DJ Hero 2 bujaclub

- One does not simply interpolate RGB565 components as U16 data!
- Just use RGB565 for all blit targets. Avoids really dumb transforms done by GPU hw.
- When X16 is used, all the channels get written to R channel alone. CmdBlit does perform format conversion!
- gl: Force image copy when blit is requested with compatible targets. Avoids format conversion issues.
@kd-11
Copy link
Contributor Author

kd-11 commented Nov 17, 2021

Format mismatch should be fixed. However, I had to touch blit engine, which means any number of games may have been broken by the changes. Freezing until more general testing is done.

@kd-11 kd-11 changed the title rsx: Texturing improvements [TESTERS NEEDED] rsx: Texturing improvements Nov 17, 2021
@kd-11 kd-11 marked this pull request as draft November 17, 2021 20:41
@Crafty-The-Fox
Copy link

Good news, the new build seems to fix the issue.

2nd, is that ive tested Skate 3 and LBP:K, and they seem to play fine. Il test a couple more games that I have on hand.

@shockdude
Copy link
Contributor

New build looks great for me too.
BLUS30526_screenshot_2021_11_17_pr11163

Also tested DJ Hero 1 and that has fixed crowds as well.

@Linear524
Copy link

I would like to test this PR but I can't build an executable on my current PC... May I ask compiled artifact of this PR in order to test it on my PS3 titles collection ?

@MSuih
Copy link
Member

MSuih commented Nov 22, 2021

You can download artifacts from Cirrus, either by using the bot in our Discord server or by following these steps:

  1. Scroll to bottom of the page for the sercion about checks, click on "Show all details" if it isn't visible
  2. Find the task for Windows and click on Details.
  3. Scroll to bottom and click "View more details on Cirrus CI"
  4. Find the artifacts section, click on the folder to open it and then click on the file that ends with ".7z"
  5. Extract the executable, rename it and drop it into your rpcs3 directory. That way you can have the main version and testing builds in the same rpcs3 directory.

For linux it's mostly the same apart from step 5 where you just launch the build from different AppImage file.

@Linear524
Copy link

You can download artifacts from Cirrus, either by using the bot in our Discord server or by following these steps:

1. Scroll to bottom of the page for the sercion about checks, click on "Show all details" if it isn't visible

2. Find the task for Windows and click on Details.

3. Scroll to bottom and click "View more details on Cirrus CI"

4. Find the artifacts section, click on the folder to open it and then click on the file that ends with ".7z"

5. Extract the executable, rename it and drop it into your rpcs3 directory. That way you can have the main version and testing builds  in the same rpcs3 directory.

For linux it's mostly the same apart from step 5 where you just launch the build from different AppImage file.

Thank you (^_^)
( My OS is Win10 @ Xeon E5 2690V4 )

@kd-11 kd-11 marked this pull request as ready for review November 22, 2021 18:26
@kd-11 kd-11 changed the title [TESTERS NEEDED] rsx: Texturing improvements rsx: Texturing improvements Nov 22, 2021
@shockdude
Copy link
Contributor

Latest PR build works and looks good to me, DJ Hero 1 and 2

@Linear524
Copy link

Tested GoW3, GoWA, TLoU, Persona5, MGS2, 3, 4, Journey, RDR.
No regression.
Killzone 2 and 3 have broken postprocessing shader, but this is not related to this PR, these bugs related to LLVM update which was fixed after a while on master branch, but not included here...

@kd-11 kd-11 merged commit 4df1a93 into RPCS3:master Nov 24, 2021
@kd-11 kd-11 deleted the dj-hero branch January 30, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splinter Cell: Blacklist Crash in the title screen Regression: DJ Hero 2 Crowd (#8769)
6 participants