New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsx: Texturing improvements #11163
rsx: Texturing improvements #11163
Conversation
This fixes the "wireframe like" issue. but I'm not sure if this was hiding behind it. Parts of the models start to disappear when the game goes farther and farther from the camera. In the 1st screenshot some of the crowd is red instead of the assumed green, and textures next to the deck are scrambled. Those issues are minor though. In the second screenshot you can also see some clipping with the models happening In the 3rd screenshot, it looks normal. This is probably because the camera is closer to the crowd. I compared the 2nd image to the screenshots from console that @shockdude posted in the issue, so it seems to be a RPCS3 issue. RSX Captures: https://mega.nz/folder/PKomkYpR#ppy0b8FWhHyTEhrIEhhrnw |
I can replicate @Crafty-The-Fox's first image. PR 11163 Master 0.0.19-13024 |
- One does not simply interpolate RGB565 components as U16 data!
- Just use RGB565 for all blit targets. Avoids really dumb transforms done by GPU hw. - When X16 is used, all the channels get written to R channel alone. CmdBlit does perform format conversion! - gl: Force image copy when blit is requested with compatible targets. Avoids format conversion issues.
Format mismatch should be fixed. However, I had to touch blit engine, which means any number of games may have been broken by the changes. Freezing until more general testing is done. |
Good news, the new build seems to fix the issue. 2nd, is that ive tested Skate 3 and LBP:K, and they seem to play fine. Il test a couple more games that I have on hand. |
I would like to test this PR but I can't build an executable on my current PC... May I ask compiled artifact of this PR in order to test it on my PS3 titles collection ? |
You can download artifacts from Cirrus, either by using the bot in our Discord server or by following these steps:
For linux it's mostly the same apart from step 5 where you just launch the build from different AppImage file. |
Thank you (^_^) |
Latest PR build works and looks good to me, DJ Hero 1 and 2 |
Tested GoW3, GoWA, TLoU, Persona5, MGS2, 3, 4, Journey, RDR. |
Fixes #10875
Fixes #9076