Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Maintenance fixes [4] #12788

Merged
merged 11 commits into from Oct 11, 2022
Merged

rsx: Maintenance fixes [4] #12788

merged 11 commits into from Oct 11, 2022

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Oct 10, 2022

  • Do not enable host fp16 by default. Instead, move to GPU tab as a shader precision setting. More options will be moved under this switch in future. Native fp16 is actually too precise, compared to what RSX expects. That is what is causing the minor glitches when it is enabled. However, it generates much better shaders than the emulated fp16 version so I have left it in for users with weaker GPUs.
  • Implement RSX-compliant polygon offset for the major GPU vendors. Polygon offset unfortunately is not portable, and different GPUs and drivers will have different calibration constants that need to be calculated and scaled to match RSX. I have covered AMD and NVIDIA on both windows and linux. Intel has not been tested, but should work just fine under vulkan. Intel + OpenGL is unsupported.

Fixes #11678
Fixes #11350
Fixes #11959
Fixes #12008
Fixes #11917

rpcs3/rpcs3qt/settings_dialog.ui Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.ui Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.cpp Show resolved Hide resolved
rpcs3/rpcs3qt/emu_settings_type.h Show resolved Hide resolved
kd-11 and others added 2 commits October 10, 2022 20:12
Co-authored-by: Megamouse <studienricky89@googlemail.com>
- Hopefully nothing breaks 🤞
@Linear524
Copy link

This PR fixes flickering shadows in God of War Ascension for my rigs (I use XeonV4 CPUs with TSX on @ GTX 1080) ! :)
Thank yo KD-11 ! :)

@marcin-przywoski
Copy link

I think this commit has increased performance a lot in older R&C games on my 5950X. The 3rd planet in R&C2 (the space station) does not have 51 fps at the beginning but very close to locked 60 now. I think I'm seeing the same improvements in ToD

@Jorforit
Copy link

I don't understand the solution, it says to disable native fp16/ implement RSX-compliant polygon. what does it mean?
I don't know why but i also can't find the box to disable this/ don't know what an RSX-compliant polygon means.
Can someone help?

@Darkhost1999
Copy link
Contributor

You don't need to do anything just update RPCS3 to reap the reward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment