Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys_fs, sys_ss, and sys_usbd: LV2 syscalls enhancements #13840

Merged
merged 4 commits into from Jun 5, 2023
Merged

sys_fs, sys_ss, and sys_usbd: LV2 syscalls enhancements #13840

merged 4 commits into from Jun 5, 2023

Conversation

brian218
Copy link
Contributor

@brian218 brian218 commented May 10, 2023 •
edited

  • Implemented sys_fs_mount() with argument prot=1 for mounting VFS devices in read only mode (mainly used by XMB).
  • Further implemented Update Manager service so that the progress of firmware update in XMB can go to 99%, tested in DEX&DECR.
  • Implemented sys_usbd_unregister_extra_ldd() and improved the other ldd-related syscalls.

@brian218 brian218 requested a review from Megamouse May 11, 2023 07:42
@brian218 brian218 requested a review from elad335 May 12, 2023 12:01
elad335
elad335 requested changes May 12, 2023
View reviewed changes
Copy link
Contributor

@elad335 elad335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread-safety matters.

@brian218
Copy link
Contributor Author

Locks have been added to sys_fs_newfs/mount/unmount syscalls earlier today.

@elad335
Copy link
Contributor

elad335 commented May 12, 2023

cellSysCache and sys_ss contain such code.

@brian218
Copy link
Contributor Author

cellSysCache and sys_ss contain such code.

Solved.

@brian218 brian218 requested a review from elad335 May 12, 2023 23:45
@brian218
Copy link
Contributor Author

Thread-safety matters.

A shared_mutex has been added to lv2_update_manager as per the request.

@brian218
Copy link
Contributor Author

While waiting for this PR's getting attention from the major developers, I made the progress of XMB's firmware update feature go farther, though it hasn't been fully supported yet.

screenshot_2023_05_19_00_44_51
screenshot_2023_05_19_00_44_54
screenshot_2023_05_19_00_44_58
screenshot_2023_05_19_00_45_30

@Megamouse
Copy link
Contributor

"While waiting for this PR's getting attention from the major developers"
It's not gonna get faster if you add more stuff xd

@Megamouse Megamouse added the VSH label May 18, 2023
@brian218
Copy link
Contributor Author

"While waiting for this PR's getting attention from the major developers" It's not gonna get faster if you add more stuff xd

With new features and improvements, there's no loss for me honestly. XD

Comparison with v0.0.27-15025-08c1a14b:
screenshot_2023_05_19

@Megamouse
Copy link
Contributor

hi, could you be so kind and test the usio config in #13896 ?

@brian218 brian218 changed the title sys_fs: Implemented sys_fs_mount(prot=1) read-only mounting & fixed up some operation and permission checks sys_fs, sys_ss, and sys_usbd: LV2 syscalls enhancements May 23, 2023
@brian218 brian218 mentioned this pull request May 23, 2023
Merged
3 tasks
@brian218 brian218 requested a review from elad335 June 5, 2023 05:00
@kd-11 kd-11 merged commit c857759 into RPCS3:master Jun 5, 2023
5 checks passed
@shinra-electric shinra-electric mentioned this pull request Jun 5, 2023
Closed
@Hadrianneue
Copy link

Gran Turismo 6 crashing on startup, works fine on previous build 0.0.28-15120.

RPCS3.zip

@brian218
Copy link
Contributor Author

brian218 commented Jun 5, 2023

Gran Turismo 6 crashing on startup, works fine on previous build 0.0.28-15120.

RPCS3.zip

Kindly submit a formal issue report at https://github.com/RPCS3/rpcs3/issues/new/choose with the required information.

@Megamouse Megamouse mentioned this pull request Jun 5, 2023
Merged
@Megamouse Megamouse mentioned this pull request Jun 5, 2023
Merged
@ItsLaguna ItsLaguna mentioned this pull request Jun 7, 2023
Closed
This was referenced Jun 8, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oltolm oltolm oltolm left review comments

@Megamouse Megamouse Megamouse left review comments

@elad335 elad335 elad335 approved these changes

Assignees
No one assigned
Labels
Filesystem Firmware: HLE VSH
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brian218 @elad335 @Megamouse @Hadrianneue @oltolm @kd-11