Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: Bugfixes #13948

Merged
merged 5 commits into from Jun 5, 2023
Merged

debugger: Bugfixes #13948

merged 5 commits into from Jun 5, 2023

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Jun 4, 2023

  • Do not access IDM's containers when their FXO entry is inactive.
  • Save smart thread pointers in the debugger instead of raw pointers.
  • Fix segfault when a double click signal occurs after ui callstack has been cleared.
  • Add return key press in addition to double click to jump to callstack item address.
  • Fix debugger shortcuts when callstack is the focused widget.

Fixes #13865

@elad335 elad335 force-pushed the gt5-fix branch 2 times, most recently from 948ce12 to 62c1994 Compare June 4, 2023 14:31
@AniLeo
Copy link
Member

AniLeo commented Jun 4, 2023

@jbeich we have an issue with the FreeBSD CI

pkg: No packages available to install matching 'llvm16' have been found in the repositories

@jbeich
Copy link
Contributor

jbeich commented Jun 4, 2023

FreeBSD package build failed unlike before. Probably due to a hardware/kernel hiccup. The package recipe had a change but for aarch64 and unlikely to break build on amd64.

llvm16 will re-apper in ~4 days. The next build will auto-start on Tuesday 01:00 UTC and may take ~2 days until completion. I've opened #13949 as a workaround and to fix an unrelated issue (upcoming 13.1 EOL).

@elad335 elad335 force-pushed the gt5-fix branch 2 times, most recently from c57f8df to c2852a2 Compare June 5, 2023 00:08
@elad335 elad335 force-pushed the gt5-fix branch 2 times, most recently from c1f086c to 431945e Compare June 5, 2023 05:59
@elad335 elad335 changed the title debugger: Fix use of invalid pointers debugger: Bugfixes Jun 5, 2023
@Nekotekina Nekotekina merged commit e75c0db into RPCS3:master Jun 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddressSanitizer: heap-use-after-free in IdManager.h:715
5 participants