-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Util/fixed_typemap.hpp: Fixes #14896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Dec 14, 2023
•
edited
edited
- Set up a trap for uninitialized access to FXO objects, see Fix fxo dependencies #14897.
- Fix independent threads with FXO management, launch threads only after all default-constructibles have been created.
- Resolve a dependency chain between PSN handler and network thread.
- Fix TCP monitor thread abort in some cases, the previous bug could have led to deadlocks when trying to quit games.
- Fix UB with g_fxo->init regarding multi-threaded access in some cases.
Merged
Megamouse
changed the title
Util/fixed_typemap.hpp: set unitialiazed data to trap values
Util/fixed_typemap.hpp: set uninitialized data to trap values
Dec 14, 2023
elad335
force-pushed
the
dump-ptr
branch
2 times, most recently
from
December 14, 2023 20:24
feb0cf0
to
613449b
Compare
elad335
force-pushed
the
dump-ptr
branch
11 times, most recently
from
December 17, 2023 21:10
91c440c
to
614bc88
Compare
elad335
force-pushed
the
dump-ptr
branch
2 times, most recently
from
December 18, 2023 20:02
dba45eb
to
42e8b2a
Compare
elad335
changed the title
Util/fixed_typemap.hpp: set uninitialized data to trap values
Util/fixed_typemap.hpp: Fixes
Dec 18, 2023
elad335
force-pushed
the
dump-ptr
branch
2 times, most recently
from
December 19, 2023 12:38
ff4b883
to
df0f919
Compare
Now safe as long as no- object is created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.