Fix fxo dependencies #14897
Merged
Fix fxo dependencies #14897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
force-pushed
the
fxo_fixes
branch
2 times, most recently
from
18fde3f
to
b3cbed9
Compare
elad335
reviewed
Dec 14, 2023
kd-11
reviewed
Dec 14, 2023
| @@ -2412,20 +2413,20 @@ void VKGSRender::close_and_submit_command_buffer(vk::fence* pFence, VkSemaphore | |||
| primary_submit_info.wait_on(wait_semaphore, pipeline_stage_flags); | |||
| } | |||
|
|
|||
| auto& async_scheduler = g_fxo->get<vk::AsyncTaskScheduler>(); | |||
| if (async_scheduler.is_recording()) | |||
| if (auto async_scheduler = g_fxo->try_get<vk::AsyncTaskScheduler>(); | |||
There was a problem hiding this comment.
Pretty sure the task scheduler should always exist, at least with the current code model. I'll have to check this properly when I have the time, otherwise it can cause nasty GPU hangs and/or BSODs.
There was a problem hiding this comment.
No. it depends on the async compute capability
There was a problem hiding this comment.
Which I don't have for some reason
There was a problem hiding this comment.
ah. it needs async texture streaming. Otherwise the object is not created.
There was a problem hiding this comment.
Only if supports_asynchronous_compute property is true it is created, I believe this is mergeable because its needed for more changes.
Megamouse
force-pushed
the
fxo_fixes
branch
3 times, most recently
from
677a93c
to
6e8bcef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some dependency issues revealed by #14896