Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve savestates #14953

Merged
merged 9 commits into from Dec 29, 2023
Merged

Fix and improve savestates #14953

merged 9 commits into from Dec 29, 2023

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Dec 28, 2023

  • Fix audio_out_configuration initialization. This was a recent regression caused by Fix fxo dependencies #14897.
  • Fix SPU access violations when loading savestates with SPU LLVM.
  • Implement SPU reservation saving, remove its hack.
  • Add data tags in savestates to ensure state integrity on savestate load.
  • Improve compression rate of savestate by saving PS3 memory blocks together.
  • Invalidate all old savestates.
  • Add saving date and time and RPCS3 build title to the file data itself.

@elad335 elad335 added Enhancement Bugfix Savestates Anything that involves savestates LLVM Related to LLVM instruction decoders Caution: Breaks Backwards Compatibility Changes that breaks backwards compatibility labels Dec 28, 2023
@elad335 elad335 force-pushed the dump-ptr branch 3 times, most recently from 2062fea to cf613b9 Compare December 28, 2023 20:46
@elad335
Copy link
Contributor Author

elad335 commented Dec 29, 2023

There is an RSX thread segfault on savestate load left on some occasions but I will leave it to kd-11.

Sneaky bug: allow invalidation from blocks that do not contain a store but do a gpr-state critical operation.
@elad335 elad335 force-pushed the dump-ptr branch 2 times, most recently from bc48e31 to 1a3d207 Compare December 29, 2023 08:24
@elad335 elad335 merged commit 9f6c538 into RPCS3:master Dec 29, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Caution: Breaks Backwards Compatibility Changes that breaks backwards compatibility Enhancement LLVM Related to LLVM instruction decoders Savestates Anything that involves savestates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant