Fix cellPadGetData #5311
Fix cellPadGetData #5311
Conversation
|
Fixes press x in williams pinball and makes it go ingame. Also fixes chime super deluxe. |
|
List of known fixed games:
|
|
Does this apply for games that doesnt react on start up with native ui ? |
|
@Kravickas no it doesnt. |
|
Also fixes Call of Juarez Bound By Blood face button inputs on the fullgame and demo! They're both likely playable with this change. EDIT: Confirmed Call of Juarez Cartel is fixed too |
|
and Tekken Revolution is also fixed with this PR? |
|
Test it. |
* Remove complete buffer clear * If pressure sensitivity option is not specified, write zeroes (should this be handled from our actual controller handler?) * Check sensor setting before reporting changes
elad335
force-pushed
the
cellPadGetData
branch
from
e2b50ec
to
5f43d54
Compare
|
Changed a few things according to a hwtest:
|
|
@Asinin3 tested and does not fix! |
|
This PR also fixes the game "nail'd". Buttons now work. |
| data->button[CELL_PAD_BTN_OFFSET_PRESS_R1] = pad->m_press_R1; | ||
| data->button[CELL_PAD_BTN_OFFSET_PRESS_R2] = pad->m_press_R2; | ||
| } | ||
| if (pad->m_port_setting & CELL_PAD_SETTING_PRESS_ON) |
There was a problem hiding this comment.
Are we missing some length checks? Or is the check against CELL_PAD_LEN_NO_CHANGE enough? There is a check against CELL_PAD_LEN_CHANGE_PRESS_ON that was removed here, I'm just wondering if this could now overflow.
There was a problem hiding this comment.
Yes, CELL_PAD_LEN_NO_CHANGE check is enough. the test shows that its modified regardless of the option or the lengh if there was any new data. which is why I removed a comment saying that realhw only writes up to len.
Dont write to press data buffer if CELL_PAD_SETTING_PRESS_ON option was not specified. For now remove clear for other unused parts of the buffer, if a testcase is needed I can write it but I know testing this kinda stuff is a little tricky. Fixes dead island (#5215)