Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAD: Fix ldd_data transfer #15606

Merged
merged 1 commit into from
May 18, 2024
Merged

PAD: Fix ldd_data transfer #15606

merged 1 commit into from
May 18, 2024

Conversation

Florin9doi
Copy link
Contributor

@Florin9doi Florin9doi commented May 18, 2024 •
edited
Loading

  • ldd_data was set but unused

@Megamouse
Copy link
Contributor

just invert the assignment.
I accidentally changed this during refactoring.
image

@elad335
Copy link
Contributor

elad335 commented May 18, 2024 •
edited
Loading

In the rest of the function only data->len bytes are actually modified, see #5311. This should be done here too using memcpy.

@Megamouse
Copy link
Contributor

How is this supposed to fix native overlay input?
I understand that it may fix my other PR, but on its own?

@Florin9doi
Copy link
Contributor Author

How is this supposed to fix native overlay input? I understand that it may fix my other PR, but on its own?

You're right, I removed the link

@Florin9doi Florin9doi mentioned this pull request May 18, 2024
Merged
@Megamouse Megamouse merged commit dc05d38 into RPCS3:master May 18, 2024
6 checks passed
@Florin9doi Florin9doi deleted the lddpad branch May 18, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elad335 elad335 elad335 left review comments

@Megamouse Megamouse Megamouse left review comments

Assignees
No one assigned
Labels
Bugfix Firmware: HLE Input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Florin9doi @Megamouse @elad335