Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microphone emulation #5446

Merged
merged 1 commit into from Jul 11, 2019
Merged

Microphone emulation #5446

merged 1 commit into from Jul 11, 2019

Conversation

RipleyTom
Copy link
Contributor

@RipleyTom RipleyTom commented Dec 21, 2018

Supports 4 microphone types:
-Standard: your basic microphone
-Singstar: fakes a singstar microphone device
-Real Singstar: if you want to use your real singstar microphones
-Rocksmith: to use with rocksmith games and your rocksmith dongle( thanks @jjsat )

Configuration is under the Audio tab.

@Zangetsu38
Copy link
Contributor

Zangetsu38 commented Dec 22, 2018

little forget tooltip jso, i have add

"microphoneBox": "Select your mic device ps3.",

@RipleyTom
Copy link
Contributor Author

Good catch, added a tooltip.

@LuismaSP89
Copy link

Great job :P another ps3 accesory emulated. If you want to try next with Buzz controllers you have my blessing xD

@RipleyTom RipleyTom changed the title Singstar microphone emulation [WIP] Singstar microphone emulation Jan 1, 2019
@RipleyTom RipleyTom changed the title [WIP] Singstar microphone emulation [WIP] microphone emulation Jan 1, 2019
@RipleyTom RipleyTom changed the title [WIP] microphone emulation [WIP] Microphone emulation Jan 1, 2019
@psennermann
Copy link

"Singstar vol.1" works really good with any microphone, while "Singstar Vasco" doesn't work (although I have an original Singstar USB converter attached to the usb port, that game keeps on asking to attach one…)

The only minor problems I encountered on my PC with "Singstar vol. 1" are:

  • FMV video is out of sync compared to audio (but fortunately text words are perfectly in sync)

  • using 2 Singstar microphones with the usb converter they're recognised as one (like what happens in the Windows 10 audio manager); so if you wanna play duett you have to attach another usb microphone...

  • when you want to rehear the singed song, the music is all messed up (maybe Audio Buffering + Refactoring #5456 could help in this case?)

@RipleyTom
Copy link
Contributor Author

I added support(untested) for real Singstar devices.
Also added UI so you can select the microphones you want to use specifically.
As for Singstar Vasco I didn't have time to investigate why it doesn't recognize the device yet.

@psennermann
Copy link

Using "Real Singstar" option, microphone doesn't work well (it has a "muffled/garbled" sound somewhat like what you hear when you want to rehear the singed song), while using two microphones attached to the Singstar usb converter, every microphone outputs voice for both blue and red microphone (like you were singing with both at the same time)

@jjsat
Copy link
Contributor

jjsat commented Apr 7, 2019

I added some code for using a Rocksmith USB cable with this PR. That cable acts as a mono microphone. The code is enough to get the game to recognize an attached guitar and to process input from it. Not sure if it entirely correct though since the game has a lot of audio output stutter (disabling framelimit and using Null renderer helps a bit).

There is one big hack in cellMicOpenEx, which Rocksmith 2014 calls with rawChannel=4. This value is ignored and hard set to 1 for mono input. Not sure what to make of this, maybe it is more like maxChannels in cellMicOpenRaw?

Changes are here: jjsat@70119ab

@RipleyTom RipleyTom changed the title [WIP] Microphone emulation Microphone emulation May 9, 2019
@RipleyTom
Copy link
Contributor Author

Did a bit of spring cleaning, tested on linux, added rocksmith support as suggested by @jjsat .
Biggest surprise is that it seems to now work perfectly with Karaoke Revolution which I couldn't figure the issues with. Apparently the issues were not with my cellMic implementation so I'm removing the [WIP].

@RipleyTom RipleyTom force-pushed the daMic branch 2 times, most recently from f157681 to 69f0d06 Compare May 9, 2019 23:54
@psennermann
Copy link

No problems to report

@LonelyDragon123
Copy link

I have problem in Guitar Hero. Even with original Logitech guitar hero mic I have loud noise, and if I say something it changes a little, which means mic working, but sound input very distorted.

Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits

rpcs3/Emu/Cell/Modules/cellAvconfExt.cpp Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.cpp Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Show resolved Hide resolved
@RipleyTom RipleyTom force-pushed the daMic branch 2 times, most recently from 115f2b7 to f5004c5 Compare May 30, 2019 12:38
@RipleyTom
Copy link
Contributor Author

@LonelyDragon123 make sure you're using standard microphone(in the microphone type combobox in audio tab) with guitar hero. I just tested guitar hero 5 and it worked perfectly.

@Megamouse Megamouse added the GUI label May 31, 2019
@RipleyTom RipleyTom changed the title Microphone emulation [Rework In Progress] Microphone emulation Jun 20, 2019
@RipleyTom RipleyTom force-pushed the daMic branch 2 times, most recently from 6e55fb7 to 6f6bfd1 Compare June 20, 2019 19:50
@RipleyTom RipleyTom force-pushed the daMic branch 2 times, most recently from 8240e59 to 448b776 Compare June 20, 2019 20:55
@RipleyTom RipleyTom changed the title [Rework In Progress] Microphone emulation Microphone emulation Jun 20, 2019
rpcs3/Emu/Cell/Modules/cellMic.cpp Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet