Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] vk: Spec fixups #5509

Merged
merged 1 commit into from
Jan 5, 2019
Merged

[Hotfix] vk: Spec fixups #5509

merged 1 commit into from
Jan 5, 2019

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Jan 5, 2019

Spec cleanups

  • Forgot to update descriptor pool init sizes over time. Updated sizes should fix descriptor pools running out of resources with only 25% occupancy.
  • Do not use VK_WHOLE_SIZE for the null resource bind since most drivers have uniformBufferRange limits much much smaller.
  • Also clamp swapchain resources to allowable surface extents.

Should fix the following:

@kd-11
vk: Spec fixups
16fe220 
- Forgot to update descriptor pool init sizes over time
- Also clamp swapchain resources to allowable surface extents
@kd-11 kd-11 changed the title vk: Spec fixups [Hotfix] vk: Spec fixups Jan 5, 2019
@kd-11 kd-11 merged commit a13986e into RPCS3:master Jan 5, 2019
This was referenced Jan 5, 2019
Closed
Closed
Closed
@paxsyr paxsyr mentioned this pull request Feb 3, 2019
Closed
@toccata10 toccata10 mentioned this pull request Feb 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kd-11