rsx: Texturing improvements #5675

kd-11 · 2019-02-20T20:17:48Z

Improves texture search logic by attempting to 'merge' the surface store data and the texture cache data whenever overlaps are encountered. A full data collapse would be infeasible due to performance concerns, but since the two sources are optionally data locked, this should almost always resolve correctly especially when WCB is enabled.

This PR is still very WIP and has been made available for testing. Please look out for significant graphical or performance regressions. Optimizations are still ongoing.

Glitched:

MarioSonic2987 · 2019-02-20T21:39:36Z

Fixes these graphical issues in the following games:

Brain Challenge - Broken effects in Stress Test (waving or blur)

Dark Souls II - White textures when you get into interiors

Kingdom Hearts II Final Mix - Broken glow in screen after defeating bosses

Rayman Legends - Missing bloom and blurred background

Resident Evil 6 - Broken special effects in menus and black textures

Saints Row: The Third - Black graphics

Saints Row IV - Black graphics in Vulkan, LSD graphics in OpenGL

Improvements discovered by users:

Cars 2 (Yellow/Green graphics with GPU blit) - uaqlover
Cars 3: Driven to Win (Yellow/Green graphics with GPU blit) - uaqlover
Gran Turismo HD Concept (Broken reflections in cars) - AxelBogda
Gran Turismo 5 Prologue (Broken reflections) - Jenci
Gran Turismo 5 (Broken reflections) - Jenci
Kingdom Hearts Final Mix (Broken effect in Atlantica/Jafar battle) - Most users in issue Kingdom Hearts 1.5 Atlantica bug [BLUS31212] #4303
Ratchet & Clank: A Crack In Time (Broken water reflections) - stride21
Ratchet & Clank: Tools of Destruction (Broken trails) - stride21
Resident Evil Revelations 2 (Missing textures) - zombie167
Resident Evil: The Darkside Chronicles (Red shadows) - zombie167
Surf's Up (Flickering screen) - uaqlover

Ghostotakoi · 2019-02-20T23:11:46Z

Does this increase/decrease performance in any way or just increase accuracy???

stride21 · 2019-02-21T00:08:08Z

Motorstorm crashes when using Vulkan while trying to select a vehicle to use.
rpcs3log.zip

OpenGL Master:

OpenGL PR:

Resistance 3
Vulkan Master:

Vulkan PR:

OpenGL Master:

OpenGL PR:

PR fixes black screen when having low hp and using Vulkan.
Vulkan Master:

Vulkan PR:

OpenGL Master:

OpenGL PR:

OpenGL is working correctly with commit c13221d:

hyperspeedgx · 2019-02-21T00:41:30Z

can't go ingame in both ninja gaiden sigma 1 and 2

F {RSX [0x0388c98]} RSX: class std::runtime_error thrown: Verification failed (e=0x7f):
(in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vktexturecache.h:53)

RPCS3.log.gz

master build rpcs3-v0.0.0.6-7792-8b475303_win64 doesn't has the issue.

edit: lastest fbo, rpcs3-v0.0.6-3262dd76_win64, build still has the issue.

rpcs3/Emu/RSX/Capture/rsx_replay.cpp

legend800 · 2019-02-21T06:40:22Z

Backbreaker has flashing/glossy uniforms now (field textures on vk still broken):

Motorstorm crashes for me too (noted above).

Motorstorm Pacific Rift: Broken gfx, crashes on game start.

F {RSX [0x001004c]} RSX: class std::runtime_error thrown: Assertion Failed! Vulkan API call failed with unrecoverable error: Device lost (Driver crashed with unspecified error or stopped responding and recovered) (VK_ERROR_DEVICE_LOST)(in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vkhelpers.h:1278)

Split Second also crashes when launching gameplay with the same kind of error.

Conan is darker (first time I've seen any change on this game):

kd-11 · 2019-02-21T11:05:22Z

Broken data cast should be fixed, although I wouldn't be surprised if there are now new bugs introduced.

zombie167 · 2019-02-21T11:10:02Z

Resident Evil 6
The QTE flashing graphic glitch is fixed
FIX missing textures

Resident Evil Revelations 2
FIX missing textures

Resident Evil: The Umbrella Chronicles playable now

micaelis72 · 2019-02-21T12:50:04Z

MGS2 in MGS HD Collection didn't improved as I hoped. No previously missing effects are showing. I was putting some hope on this PR. Let's see in the future...

Macross 30 segfaults after the intro movie is played.

Follows the logs, I hope it helps...

RPCS3.log.gz

MarioSonic2987 · 2019-02-21T13:49:22Z

SRTT and SRIV no longer have broken garbage overlay:

Rayman Legends has correct colors:

@zombie167 I confirm that fixes black textures in Resident Evil 6.

MarioSonic2987 · 2019-02-21T14:01:28Z

Now GTA V renders the same as master.

stride21 · 2019-02-21T14:05:18Z

Motorstorm goes ingame with vulkan again but now it has a new issue where it can randomly look like the pictures I posted below.
Vulkan PR:

OpenGL PR:

RPCS3.log.gz

kd-11 · 2019-02-21T15:45:36Z

@MarioSonic2987 You mean its now darker again? I'm interested in seeing the log for that since it should contain a bad data cast ("Format incompatibility detected...") which is likely the cause of the problem.
As for the motorstorm ingame I'm investigating the cause.

MarioSonic2987 · 2019-02-21T15:57:30Z

Yes. Spams in log with:

·W 0:00:54.961531 {RSX [0x00dcca8]} RSX: Format incompatibility detected, reporting failure to force data copy (VK_FORMAT=0x7C, GCM_FORMAT=0x94)
E {RSX [0x017aba8]} RSX: Unsupported depth conversion (0x94)

Log GTA V 21-2-19 VK PR.gz

jenci8888 · 2019-02-21T18:36:20Z

The spam RSX error "Couldn't gather all slices [blah blah]" is gone, the performance is improvement GT5 when goes up 17-27fps to 20-41fps (untested GT6, once Elad PR gets merged later)
But, still appearing random rainbow car and flicker shadow (at distance view) also night has car rainbow flicker when passing and next the lamps. (problem lightmap)

Day

Night

RPCS3.log.gz

But, NFS Rivals throws error F {RSX [0x8dc010c]} RSX: class std::runtime_error thrown: Verification failed (e=0x7f): (in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vkgsrender.cpp:3313)
RPCS3_NFS_Rivals.log.gz

Krusher97 · 2019-02-21T19:37:14Z

I don't know if this is supposed touch #5526 but it doesn't change anything for it.

RPCS3.log.gz

kd-11 · 2019-02-21T19:53:47Z

@MarioSonic2987 GTA-V should be fixed now.

MarioSonic2987 · 2019-02-21T20:18:21Z

No change with the newest commit.

kd-11 · 2019-02-21T20:26:02Z

Need new log file.

MarioSonic2987 · 2019-02-21T20:28:16Z

Log GTA V 21-2-19 VK PR New

Parthorisian · 2019-02-22T11:41:36Z

Conan [BLUS30069] - just a white screen (WCB required to get ingame image similar to legend800 screenshot

kd-11 · 2019-02-22T12:23:13Z

@MarioSonic2987 Looks like there is another format conversion that needs changing, but I'm thinking it needs a separate PR since the hacky fix for it will likely break other games.

arabek · 2019-02-22T12:55:20Z

Motorstorm seems to be affected by some dynamic buffer scaling issues (NP2 textures?)

E {RSX [0x05033f0]} RSX: Could not blit depth/stencil image. src_fmt=0x0, src=1080x3684, dst=2160x3684
E {RSX [0x01833f0]} RSX: Could not blit depth/stencil image. src_fmt=0x0, src=1080x3723, dst=2160x3723
E {RSX [0x04e4a90]} RSX: Could not blit depth/stencil image. src_fmt=0x0, src=1080x3762, dst=2160x3762
E {RSX [0x0164a98]} RSX: Could not blit depth/stencil image. src_fmt=0x0, src=1080x3801, dst=2160x3801

Manifests itself in the log when using video resolution upscaling (in my case set to 300%).

uaqlover · 2019-02-22T17:45:28Z

Cars 2 [BLUS30725]

Master :

PR:

Cars 3: Driven to Win [NPUB31858]

Master :

PR:

broken games

Rio™ [BLUS30614]

Master :

PR:

Ben 10™ Galactic Racing [BLUS30822]

Master :

PR:

OPENGL

F {RSX [0x0000000]} RSX: class std::runtime_error thrown: Verification failed (e=0x7f):
(in file c:\projects\rpcs3\rpcs3\emu\rsx\gl\glhelpers.h:899)

Vulkan

F {RSX [0x01902b4]} RSX: class std::runtime_error thrown: Assertion Failed! Vulkan API call failed with unrecoverable error: Device lost (Driver crashed with unspecified error or stopped responding and recovered) (VK_ERROR_DEVICE_LOST)
(in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vkhelpers.h:1278)

jenci8888 · 2019-02-22T21:27:00Z

Fixed shadow (at distance view)
but quite drop performance, the performance almost same as master build. (still no RSX errors, yet.)

RPCS3.log.gz

Regression the broken Sonic All Star Racing Transform, unable to see the render view

RPCS3_Sonic_transformed_Racing.log.gz

uaqlover · 2019-02-23T04:18:28Z

0.0.6-5fa96219

I confirm that fixes black textures in

Ben 10™ Galactic Racing [BLUS30822]

Master

PR:

rio is same

- When a single row is required or is all that is available, pitch has no meaning as the coordinate space changed to 1D

- Seems to occupy bits [8-9]

…erated blit engine - Properly collapse memory tree when scanning in case of overlaps!

- Avoids blindly reusing blit dst sections as they may contain garbage. If a section was unlocked for a flush, just discard it as its reuse introduces potential data corruption. Since the data needs to be reuploaded anyway (for now), its better to start afresh - In case of format mismatch, reset the calculated dst block - Add a bounds check to determine if data contained in an atlas is good enough for sampling the cache. If not enough data is provided, fall back to full upload

- Build-up to variable-sized framebuffers and AA implementation - Also allows accurate range calculation for our hit testing

kd-11 · 2019-03-09T11:22:27Z

After looking at some pseudo-regressions like genji, it has become obvious that they cannot be fixed in this PR as they require features that are yet to be implemented (e.g blit engine rotations). The old way worked because it was so broken that the wrong data was getting to the GPU. Rolling back the commits and enforcing strict memory management rules shows the same issues on master. Most of the noted regressions simply disappear when using WCB+CPU blit for this reason.
As such, this PR will be merged as-is for now and a follow-up PR will be done to address the missing features.

stride21 · 2019-03-09T15:20:18Z

PR Vulkan:

PR OpenGL:

Master Vulkan:

OpenGL Master:

stride21 · 2019-03-09T17:33:31Z

OpenGL Ratchet and Clank Future: A Crack In Time looks to have regressed when aiming, it can still look correct occasionally depending on where your looking.
OpenGL PR:

Vulkan PR:

OpenGL Master:

RPCS3.log.gz

legend800 · 2019-03-10T02:00:55Z

Decided to do a full pass on my collection (~40 games). Only found two more regressions to note:

Burnout Crash:
No longer playable - mad flickering of objects in levels following by a crash within a min or so (2/2 repro). GFX/stability perfect on Master. Happens with/w/o WCB+Blit.

S {RSX Decompiler Thread} RSX: New program compiled successfully x6
F {RSX [0x025d690]} RSX: class std::runtime_error thrown: Verification failed:
(in file c:\projects\rpcs3\rpcs3\emu\rsx\common\texture_cache.h:2101)

Motorstorm Apoc.
Does a weird thing now, where it shows a discolored edge that moves itself to the edge of screen and makes the black border bigger than normal. Strange.

Master:

PR:

Then transitions to this....

kd-11 · 2019-03-10T13:08:59Z

Regression tracker at #5708

arcadee1977 · 2019-03-12T10:33:56Z

regression: GOW3 image trembling without FCB

kd-11 · 2019-03-12T10:37:54Z

Stop commenting here, comment at #5708 instead. The GOW3 issue has already been raised there.

elad335 reviewed Feb 21, 2019

View reviewed changes

rpcs3/Emu/RSX/Capture/rsx_replay.cpp Outdated Show resolved Hide resolved

kd-11 force-pushed the fbo_fixes branch from 7e7568a to dc00a18 Compare February 21, 2019 10:40

kd-11 force-pushed the fbo_fixes branch from dc00a18 to 02ede06 Compare February 21, 2019 19:53

kd-11 force-pushed the fbo_fixes branch from 02ede06 to 8f627f4 Compare February 21, 2019 19:55

kd-11 force-pushed the fbo_fixes branch from 8f627f4 to 52ba462 Compare February 22, 2019 20:13

kd-11 added 7 commits March 9, 2019 14:16

rsx: Implement proper pitch compatibility lookup

7ca076d

- When a single row is required or is all that is available, pitch has no meaning as the coordinate space changed to 1D

rsx: Properly decode packed renders from the type flag

f0e1c8f

- Seems to occupy bits [8-9]

rsx: Reimplement render target intersection tests when using hw accel…

132e829

…erated blit engine - Properly collapse memory tree when scanning in case of overlaps!

rsx: Properly generate render target data with all parameters provided

87df755

- Build-up to variable-sized framebuffers and AA implementation - Also allows accurate range calculation for our hit testing

cleanup and fixups

9fb4fa5

gl: Fix buffer size calculations

002aa33

kd-11 force-pushed the fbo_fixes branch from c109181 to 002aa33 Compare March 9, 2019 11:17

kd-11 changed the title ~~[VERY WIP] rsx: Texturing improvements~~ rsx: Texturing improvements Mar 9, 2019

kd-11 mentioned this pull request Mar 10, 2019

Regressions from #5675 #5708

Closed

13 tasks

kd-11 merged commit 1875dc3 into RPCS3:master Mar 10, 2019

MarioSonic2987 mentioned this pull request Mar 10, 2019

GL/Vulkan: Saints Row: The Third/IV/Gat Out of Hell graphical issues #3545

Closed

4 tasks

legend800 mentioned this pull request Mar 10, 2019

BACKBREAKER VENGEANCE [NPEB00592]: Field texture cache gets corrupted after switching stadiums #5020

Closed

uaqlover mentioned this pull request Mar 11, 2019

Conan [BLES00076] soft locks on data load screen #4856

Closed

This was referenced Mar 16, 2019

Rampage World Tour [NPUB30003] issue #5658

Closed

rsx: Texturing improvements followup #5726

Merged

Kravickas mentioned this pull request Mar 19, 2019

rsx: Fixups #5741

Merged

kd-11 mentioned this pull request Mar 19, 2019

Kingdom Hearts 1.5 Atlantica bug [BLUS31212] #4303

Closed

Psycho-A mentioned this pull request Mar 22, 2019

Silent Hill: Downpour regressed to In-game #5160

Closed

legend800 mentioned this pull request Apr 11, 2019

[Regression] NFL Blitz has an blue square overlaid on image (caused by PR 5675 - RSX Texturing Improvements) #5824

Closed

stride21 mentioned this pull request Jun 21, 2019

Regression: Heavy Rain glitched textures PR5726 #5872

Closed

Realmantik mentioned this pull request Jul 9, 2019

resident evil 4 [NPEB00342] - Crash after "Six years later..." #6066

Closed

xddxd mentioned this pull request Oct 14, 2020

Madden 17 Freezing Issue (BLUS31589) #9049

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rsx: Texturing improvements #5675

rsx: Texturing improvements #5675

kd-11 commented Feb 20, 2019 •

edited

MarioSonic2987 commented Feb 20, 2019 •

edited

Ghostotakoi commented Feb 20, 2019 •

edited

stride21 commented Feb 21, 2019 •

edited

hyperspeedgx commented Feb 21, 2019 •

edited

legend800 commented Feb 21, 2019

kd-11 commented Feb 21, 2019

zombie167 commented Feb 21, 2019 •

edited

micaelis72 commented Feb 21, 2019

MarioSonic2987 commented Feb 21, 2019 •

edited

MarioSonic2987 commented Feb 21, 2019

stride21 commented Feb 21, 2019

kd-11 commented Feb 21, 2019

MarioSonic2987 commented Feb 21, 2019

jenci8888 commented Feb 21, 2019 •

edited

Krusher97 commented Feb 21, 2019

kd-11 commented Feb 21, 2019

MarioSonic2987 commented Feb 21, 2019

kd-11 commented Feb 21, 2019

MarioSonic2987 commented Feb 21, 2019 •

edited

Parthorisian commented Feb 22, 2019 •

edited

kd-11 commented Feb 22, 2019

arabek commented Feb 22, 2019 •

edited

uaqlover commented Feb 22, 2019

jenci8888 commented Feb 22, 2019 •

edited

uaqlover commented Feb 23, 2019

kd-11 commented Mar 9, 2019

stride21 commented Mar 9, 2019

stride21 commented Mar 9, 2019 •

edited

legend800 commented Mar 10, 2019

kd-11 commented Mar 10, 2019

arcadee1977 commented Mar 12, 2019 •

edited

kd-11 commented Mar 12, 2019

rsx: Texturing improvements #5675

rsx: Texturing improvements #5675

Conversation

kd-11 commented Feb 20, 2019 • edited

MarioSonic2987 commented Feb 20, 2019 • edited

Ghostotakoi commented Feb 20, 2019 • edited

stride21 commented Feb 21, 2019 • edited

hyperspeedgx commented Feb 21, 2019 • edited

legend800 commented Feb 21, 2019

kd-11 commented Feb 21, 2019

zombie167 commented Feb 21, 2019 • edited

micaelis72 commented Feb 21, 2019

MarioSonic2987 commented Feb 21, 2019 • edited

MarioSonic2987 commented Feb 21, 2019

stride21 commented Feb 21, 2019

kd-11 commented Feb 21, 2019

MarioSonic2987 commented Feb 21, 2019

jenci8888 commented Feb 21, 2019 • edited

Krusher97 commented Feb 21, 2019

kd-11 commented Feb 21, 2019

MarioSonic2987 commented Feb 21, 2019

kd-11 commented Feb 21, 2019

MarioSonic2987 commented Feb 21, 2019 • edited

Parthorisian commented Feb 22, 2019 • edited

kd-11 commented Feb 22, 2019

arabek commented Feb 22, 2019 • edited

uaqlover commented Feb 22, 2019

jenci8888 commented Feb 22, 2019 • edited

uaqlover commented Feb 23, 2019

kd-11 commented Mar 9, 2019

stride21 commented Mar 9, 2019

stride21 commented Mar 9, 2019 • edited

legend800 commented Mar 10, 2019

kd-11 commented Mar 10, 2019

arcadee1977 commented Mar 12, 2019 • edited

kd-11 commented Mar 12, 2019

kd-11 commented Feb 20, 2019 •

edited

MarioSonic2987 commented Feb 20, 2019 •

edited

Ghostotakoi commented Feb 20, 2019 •

edited

stride21 commented Feb 21, 2019 •

edited

hyperspeedgx commented Feb 21, 2019 •

edited

zombie167 commented Feb 21, 2019 •

edited

MarioSonic2987 commented Feb 21, 2019 •

edited

jenci8888 commented Feb 21, 2019 •

edited

MarioSonic2987 commented Feb 21, 2019 •

edited

Parthorisian commented Feb 22, 2019 •

edited

arabek commented Feb 22, 2019 •

edited

jenci8888 commented Feb 22, 2019 •

edited

stride21 commented Mar 9, 2019 •

edited

arcadee1977 commented Mar 12, 2019 •

edited