High DPI Icons

[Megamouse]

Improves Game Icon quality when using a higher device pixel ratio.
Improves the game compatibility circle icon quality.
fixes #5885

Please test on different monitors (especially on 4K devices) with different window and/or icon scaling.

Thank you @drysalter for the circle idea and Daginatsuko for showing me how bad the game icons actually look on her monitor.

My results on a 4K Screen with 200% window scaling:

List Circles:

Grid Circles:

List Icons (Smallest icon scale):

Grid Icons (Smallest icon scale):

Grid Custom config icons:

[MSuih]

Woudn't this need to be changed as well? I can't test it myself since I don't have a HiDPI screen.

rpcs3/rpcs3/rpcs3qt/game_list_frame.cpp

Line 1049 in a703460

painter.drawEllipse(spacing, spacing, size, size);

Also, I've read somewhere that wrapping the arguments inside QRectF could improve accuracy when dealing with non-integer scale factors, you could try that if there's still some issues with the current implementation. We could also consider applying some antialiasing to the circles to further improve smoothness of them, the edges look aliased on 1080p.

[Megamouse]

it's bugged anyway.

[ghost]

Thank you for this.

I've tried it out. In list view both the game icons and the circles look much better. In grid view, the game icons look good, but at the larger sizes the circles look a bit jagged, perhaps highlighted by their outline.

In grid view, the custom config icons are still pixelated, so those should probably have the pixel ratio set as well.

Another minor gripe is that the circle isn't perfectly aligned with the text. It could be dropped a bit lower:

[Megamouse]

@drysalter I fixed the circle offset. But actually most of the offset originates in the font and not the circle itself.
And btw, I actually didn't even try to improve the circles in the game grid...
But ironically they will look a lot better with higher pixel ratios as a side effect of my game icon commit.

@MSuih I won't be using qreal for now since I have already exhausted my patience with these changes and I don't wanna test it anymore XD.
Also, the icons look a lot better in any configuration I tested and tbh I never really noticed it before Daginatsuko pointed it out.... so I guess this would be a very minor nitpick if someone notices anything at all.

[Megamouse]

I added some screenshots of my results

[ghost]

Ah, apparently the alignment depends on the size the user sets.

I suppose the custom config icon can't be fixed by setting the pixel ratio since it's a .png?

[MSuih]

The image resource for custom config is fairly large, you'd have to stretch it quite large before you'll start seeing individual pixels. Still, having it (and the other icons) as an .svg would be neat, but that'd require redrawing.

[Megamouse]

Well... I applied the same approach for those config icons now.
But I really don't wanna make this an overhaul.
Honestly I only intended to fix the game icons on 4K screens and not the whole GUI ;)

custom config icons in the game grid: (remember, this is zoomed in)

[ghost]

Looks much better on my end too, thanks!

EDIT: Might want to add that this PR fixes #5885

[DanteBC]

Mega, can you also maybe add white outline on custom config icons? They're kinda hard to see on gray background sometimes. I can post examples if you want

[Megamouse]

no, sorry, that would require new source icons