[WIP] SPU PIC support #5944

Nekotekina · 2019-05-10T13:03:02Z

Settings:

Block size: Safe or Mega
SPU LLVM

isJuhn · 2019-05-10T13:59:12Z

Spider-Man Shattered Dimensions [BLES00946] stops compiling spu code just after boot, rpcs3 stops responding if you mess with ui a bit. on second boot spu compilation stops on 3/100 spu programs

RPCS3.log
spu.log

legend800 · 2019-05-10T15:30:51Z

Nothing but fatals or freezes during SPU compile on my games.

Kravickas · 2019-05-10T16:38:32Z

I had good experience with LLVM Mega in NHL 16, no segfault, no freeze

isJuhn · 2019-05-11T00:55:42Z

Spider-Man Shattered Dimensions [BLES00946] now boots and see a huge improvement in terms of spu compilation. nearly all spu programs are reused now. in master 30 seconds of gameplay used to generate 11k spu programs, with 2k unique hashes. now it's 2113 programs and 2054 unique hashes from the same playtime.

ruipin · 2019-05-11T01:38:36Z

RDR now generates 7k SPU programs in the same playtime it used to generate about 100k. Stutter is virtually gone when using SPU LLVM, and I'm getting 16-23FPS where I used to get 1-16FPS (9900k @ 5.1GHz).

TLOU has regressed (might be related to the previous LLVM PR though), and no longer gets past the loading screen. UC1 also no longer manages to get to menu. If I do not use Safe, all these games I mentioned seem to crash immediately at startup.

MsDarkLow · 2019-05-11T02:22:26Z

Fist of the North Star: Ken's Rage - DEMO [NPEB90285]
SPU LLVM - Safe
Got a massive improvement, from basically Infinite SPU cache down to 5k.
There is a lot less stutter.
Doing one of the "most intensive attacks" it went from an avg of 11fps to 25-30FPS! No longer stuttering whenever an action happens.

PedroMtz20 · 2019-05-11T02:29:58Z

Metal Gear Rising Revengance got massive improvement with SPU LLVM safe, went from 100k+ SPU cache to 7k
Also better framerate but still suffers from FIFO desync event eventually making the game hang

legend800 · 2019-05-11T02:38:48Z

Splatterhouse is finally playable on the SPU LLVM! No more constant cache building! Nice work. I think this PR fixes this then: #5843

Unfortunately, Splatterhouse still gets PPU mem errors after a few mins I found out, just a lot less than ASMJIT. This is being tracked separately here: #5837

RPCS3.log

UPDATE 1:
Issue 1:
Wipeout HD hits freezes on loading the menus with existing cache (this PR bumping cache?):
F {SPU[0x2000005] Thread (WOHD_singleSPU_CellSpursKernel0) [0x3fe74]} class std::out_of_range thrown: invalid map<K, T> key
wipeout.log
Also locks up with no cache:
wipeout new cache.zip

Issue 2:
Motorstorm Apocalypse freezes while loading the menus (no cache):
RPCS3.zip

As a note, not sure if ASMJIT is supposed to be unaffected, but it at least crashes on Splatterhouse.
wipeout.zip

MSuih · 2019-05-11T02:57:26Z

Edit: Whatever issue I'm having seems to affect master as well, so it's unrelated to this PR.

arabek · 2019-05-11T04:08:44Z

Whatever issue MSuih was having i had tried it out in RDR and couldn reproduce. Works from cold cache and after emulator restart with a primed cache of 3737 spu units compiled. LLVM block size Mega.

legend800 · 2019-05-11T04:35:47Z

Updated my post above with a quick pass through some titles, noting some that are broken now on this PR. I'll continue to update it with new commit pushes.

MarioSonic2987 · 2019-05-11T06:52:19Z

Settings used: SPU LLVM in Safe mode.

Game	SPU Cache Before	SPU Cache After	Screenshot reference
BioShock Infinite	50.6k (title screen and still compiling)	~5.4k (ingame)	Screenshot
Grand Theft Auto IV	15k	6k	Screenshot
Grand Theft Auto V	31.5k (loading screen and still compiling)	8.5k (ingame)	Screenshot
Midnight Club: Los Angeles - Complete Edition	~23.5k	4.5k	Screenshot
One Piece: Pirate Warriors	~38k (only in title screen and still compiling)	5.5k (It no longer stutters when you attack or move and performance goes up to ~50 FPS in cutscenes and ~60 FPS in the first level.)	Screenshot
Saints Row: The Third - The Full Package	13k-14k (still compiling)	~6k	Screenshot
Saints Row IV	~14.1k	~5.4k	Screenshot (First mission)

hellboysss · 2019-05-11T08:12:37Z

no sound in twisted metal BCUS98106 with SPU LLVM

vsub · 2019-05-11T09:53:29Z

RPCS3 auto closes when closing the game window:
Ar NoSurge
Atelier Shallie
Atelier Escha & Loggy
Ar Tonelico Quga
Persona 5

Eternal Sonata - the game window auto closes after loading the shaders
Tales of Xillia 1\2 - Fatal Error while using ASMJIT(maybe this is what you mean by "ASMJIT don't work") and rpcs3 auto closes when closing the game window while using LLVM(maybe all games are affected by this)

Nekotekina · 2019-05-11T11:01:19Z

@vsub Try new commit. ASMJIT is currently just unsupported — it needs more work.

MSuih · 2019-05-11T11:18:03Z

Whatever that RDR safe mode issue was, it's now fixed with latest commit and I can load the game even with existing SPU cache. Mega mode still has some issues but that's not caused by this PR.

vsub · 2019-05-11T12:38:27Z

@Nekotekina Yes,all problems mentioned above are fixed and Eternal Sonata spu cache seems to be WAY better.
On master if I load a save at the first town and then the first possible save location and play the tutorial,the spu cache becomes above 100k but with this pr,it is less than 2k

And also the game runs a little fasted on this pr

Xcedf · 2019-05-11T12:41:39Z

RDR started new game, did some random moves 7,5k On Safe never had it on safe before, but on Mega begining of the game was about 35-40k, while Mega cache from whole game is ~59k
Metal Gear Revengeance Safe - 4,4k, was 55k on Mega just in the begining
Now for the bad things Mega hows fatal error window on every game with this PR
GoW 3, TloU, Infamous are stopped working on this PR, sadly Infamous and TLoU will be a fine subjects, they're also making a lot of spu cache

Xcedf · 2019-05-11T13:38:26Z

Yet Mega mode regression is a part of previous Giga PR

legend800 · 2019-05-11T15:51:46Z

On the latest build, closing emu window no longer crashes emu (on Master).

Several broken games on Master with SPU LLVM work again (Ridge Racer 7, HOTD4, Razing, Xmen, etc).

However, Wipeout and Motorstorm Apocolypse are still unstable (even with cleared cache). Both are fine on Master.

Wipeout black screen upon entergameplay:
RPCS3.log.gz

MS Apoc freezes loading menus:
RPCS3.log.gz

Ghostotakoi · 2019-05-11T20:59:21Z

This might fix j-star victory versus

Xcedf · 2019-05-11T22:11:57Z

With recent fix of Mega mode
did more tests
Heavy Rain:
Safe 4.5k Mega 1.6k
RDR:
Safe: 7.2k Mega 3.7k
Metal Gear Revengeance:
Safe: 4.4k Mega 2.2k
Far Cry 2 anoter game with countless SPU cache
Safe: 4.2k Mega 1.9k
Some sane numbers after all

arcadee1977 · 2019-05-14T02:32:48Z

@Nekotekina Musou Orochi 2 Ultimate is full speed ! Huge speed-up! Amazing!! Thank you very much!(spu ASMJIT+MEGA)

SPU LLVM no longer <1 FPS , great work ! But still random freeze in game.

tabnk · 2019-05-14T02:41:07Z

Tested Trinity: Souls of Zill O'll.

No improvement in performance.

legend800 · 2019-05-14T02:49:13Z

@tabnk Only report improvements/regressions from master.

On latest build, GOW3 is still broken on safe/mega. GOWA though, seems more stable than Master (on mega only).

arcadee1977 · 2019-05-14T03:25:21Z

Sengoku Musou 4【BLJM61144】is full speed too! This is a great PR!!

jenci8888 · 2019-05-14T08:33:32Z

Other "Koei Tecmo" games are playable for this PR.
No longer constant freezing/lagging nor crashing. (while master does.)
Excellent job, Neko-chan! 👍

Samurai Warriors 4 [NPEB02062]

RPCS3.log.gz

resadent · 2019-05-14T17:14:32Z

Just tested spu giga with latest build. Persona 5 performs way worse than with mega. ~15fps in places with lots of npcs. Got the log in case it helps. My pc is ivy bridge.
RPCS3.log.gz

Nekotekina · 2019-05-14T17:17:09Z

Don't bother with Giga, at least until I start working on it specifically.

SPU ASMJIT not supported yet. Giga mode not supported properly.

Adjust restored stack pointer for the lack of tail call.

Use GHC calling convention directly for SPU object entry points. This may address performance degradation after RPCS3#5923.

Avoid returns from the recompiler gateway, favoring tail calls. This may address performance degradation after RPCS3#5923.

Renewed and adapted for PIC and all branch types. This may address performance degradation after RPCS3#5923.

Pauses SPURS threads beyond limit automatically if set.

Also move disasm to spu_recompiler_base::dump. Interleave disasm with block target info for convenience.

Also cleanup and adapt for GHC CC.

Don't scan before the entry point. Disable stack mirror in SPU LLVM. Improve analyser logic for holes.

Tom-Neverwinter · 2019-05-15T01:27:10Z

regression for WipEout® HD Fury [BCES00664] textures pop in and out. stutter. audio is even more out of sync.
8096 seemed to work fairly well. https://pastebin.com/qZuf5Hyt

RainbowCookie32 · 2019-05-15T04:45:50Z

Report regressions on the tracker #5965

alessandro784 · 2019-05-15T10:57:50Z

strange.... . after i reboot pc now mega mode work.

Nekotekina force-pushed the pic branch from 527ed9e to f15ea57 Compare May 11, 2019 00:18

legend800 mentioned this pull request May 11, 2019

Several games are not compatable with SPU LLVM due to never-ending cache generation #5843

Closed

8 tasks

legend800 mentioned this pull request May 11, 2019

Splatterhouse freezes with SPU ASMJIT with PPU mem error #5837

Closed

Nekotekina force-pushed the pic branch from f15ea57 to aee5316 Compare May 11, 2019 11:01

Nekotekina force-pushed the pic branch 3 times, most recently from ae1444e to d2b8097 Compare May 11, 2019 19:57

Nekotekina force-pushed the pic branch from d2b8097 to c565323 Compare May 11, 2019 22:10

Nekotekina force-pushed the pic branch from 86bc975 to bfc1c8b Compare May 13, 2019 22:09

Nekotekina force-pushed the pic branch from bfc1c8b to 62f2766 Compare May 14, 2019 16:00

Nekotekina added 9 commits May 14, 2019 22:15

SPU: PIC support preview

cc8c635

SPU ASMJIT not supported yet. Giga mode not supported properly.

SPU LLVM: fix SPU termination (spu_escape) on Windows

a74fd27

Adjust restored stack pointer for the lack of tail call.

SPU: implement recompiler gateway function in assembly

f33b815

Use GHC calling convention directly for SPU object entry points. This may address performance degradation after RPCS3#5923.

SPU LLVM: regain some efficiency

2f6707d

Avoid returns from the recompiler gateway, favoring tail calls. This may address performance degradation after RPCS3#5923.

SPU LLVM: use branch patchpoints again

1eed421

Renewed and adapted for PIC and all branch types. This may address performance degradation after RPCS3#5923.

Implement 'Max SPURS Threads' option (hack)

ea554ae

Pauses SPURS threads beyond limit automatically if set.

SPU LLVM: split LLVM IR dump to spu-ir.log

82295d1

Also move disasm to spu_recompiler_base::dump. Interleave disasm with block target info for convenience.

SPU ASMJIT: add PIC support (fix)

c481472

Also cleanup and adapt for GHC CC.

SPU: fix Giga mode (kinda)

3753d27

Don't scan before the entry point. Disable stack mirror in SPU LLVM. Improve analyser logic for holes.

Nekotekina force-pushed the pic branch from 62f2766 to 3753d27 Compare May 14, 2019 19:21

Nekotekina merged commit 3753d27 into RPCS3:master May 14, 2019

Xcedf mentioned this pull request May 14, 2019

SPU PIC Issues PR5944 #5965

Closed

isJuhn mentioned this pull request May 16, 2019

RPCS3 v0.0.6-8105-3753d27a - LittleBigPlanet 3 [BCUS98362]: Unimplemented syscall syscall_253 #5974

Closed

arcadee1977 mentioned this pull request May 17, 2019

rsx: Surface cache improvements #5937

Merged

RainbowCookie32 mentioned this pull request May 19, 2019

BLES02258 Fifa 19: Game can't be loaded or unplayable after this commit 7cf11c763796b6ccc999ea749faa0e0399ef6be1 #5994

Closed

Asinin3 mentioned this pull request Jul 11, 2019

Set the default SPU Decoder to LLVM and rename SPU LLVM from "experimental" to "fastest" #6193

Merged

RainbowCookie32 mentioned this pull request Aug 31, 2019

sys_net: sys_net_bnet_select(): exceptfds not implemented (LittleBigPlanet NPUA) #6462

Closed

jeremybris mentioned this pull request Feb 19, 2020

Some games cannot boot after SPU Interrupts not implemented #5591

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] SPU PIC support #5944

[WIP] SPU PIC support #5944

Nekotekina commented May 10, 2019 •

edited

isJuhn commented May 10, 2019

legend800 commented May 10, 2019

Kravickas commented May 10, 2019 •

edited

isJuhn commented May 11, 2019

ruipin commented May 11, 2019 •

edited

MsDarkLow commented May 11, 2019

PedroMtz20 commented May 11, 2019 •

edited

legend800 commented May 11, 2019 •

edited

MSuih commented May 11, 2019 •

edited

arabek commented May 11, 2019 •

edited

legend800 commented May 11, 2019

MarioSonic2987 commented May 11, 2019 •

edited

hellboysss commented May 11, 2019

vsub commented May 11, 2019

Nekotekina commented May 11, 2019

MSuih commented May 11, 2019

vsub commented May 11, 2019

Xcedf commented May 11, 2019 •

edited

Xcedf commented May 11, 2019 •

edited

legend800 commented May 11, 2019 •

edited

Ghostotakoi commented May 11, 2019

Xcedf commented May 11, 2019

arcadee1977 commented May 14, 2019 •

edited

tabnk commented May 14, 2019

legend800 commented May 14, 2019 •

edited

arcadee1977 commented May 14, 2019 •

edited

jenci8888 commented May 14, 2019 •

edited

resadent commented May 14, 2019

Nekotekina commented May 14, 2019

Tom-Neverwinter commented May 15, 2019 •

edited

RainbowCookie32 commented May 15, 2019

alessandro784 commented May 15, 2019 •

edited

[WIP] SPU PIC support #5944

[WIP] SPU PIC support #5944

Conversation

Nekotekina commented May 10, 2019 • edited

isJuhn commented May 10, 2019

legend800 commented May 10, 2019

Kravickas commented May 10, 2019 • edited

isJuhn commented May 11, 2019

ruipin commented May 11, 2019 • edited

MsDarkLow commented May 11, 2019

PedroMtz20 commented May 11, 2019 • edited

legend800 commented May 11, 2019 • edited

MSuih commented May 11, 2019 • edited

arabek commented May 11, 2019 • edited

legend800 commented May 11, 2019

MarioSonic2987 commented May 11, 2019 • edited

hellboysss commented May 11, 2019

vsub commented May 11, 2019

Nekotekina commented May 11, 2019

MSuih commented May 11, 2019

vsub commented May 11, 2019

Xcedf commented May 11, 2019 • edited

Xcedf commented May 11, 2019 • edited

legend800 commented May 11, 2019 • edited

Ghostotakoi commented May 11, 2019

Xcedf commented May 11, 2019

arcadee1977 commented May 14, 2019 • edited

tabnk commented May 14, 2019

legend800 commented May 14, 2019 • edited

arcadee1977 commented May 14, 2019 • edited

jenci8888 commented May 14, 2019 • edited

resadent commented May 14, 2019

Nekotekina commented May 14, 2019

Tom-Neverwinter commented May 15, 2019 • edited

RainbowCookie32 commented May 15, 2019

alessandro784 commented May 15, 2019 • edited

Nekotekina commented May 10, 2019 •

edited

Kravickas commented May 10, 2019 •

edited

ruipin commented May 11, 2019 •

edited

PedroMtz20 commented May 11, 2019 •

edited

legend800 commented May 11, 2019 •

edited

MSuih commented May 11, 2019 •

edited

arabek commented May 11, 2019 •

edited

MarioSonic2987 commented May 11, 2019 •

edited

Xcedf commented May 11, 2019 •

edited

Xcedf commented May 11, 2019 •

edited

legend800 commented May 11, 2019 •

edited

arcadee1977 commented May 14, 2019 •

edited

legend800 commented May 14, 2019 •

edited

arcadee1977 commented May 14, 2019 •

edited

jenci8888 commented May 14, 2019 •

edited

Tom-Neverwinter commented May 15, 2019 •

edited

alessandro784 commented May 15, 2019 •

edited