New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vk: Restructure present mechanism #6069
Conversation
- Just use a semaphore and let the driver handle it instead of manual framepacing. We lose framepace control but drivers have matured in the past few years so it should work fine.
You can remove the log message that I added the other day in VKhelpers.h at line 440 now. Edit: Thanks as well for the framepacing fix, 60hz games feel dramatically smoother on my 120hz monitor |
- Removes a lot of wm_event code that was used to perform window management and is no longer needed. - Significantly simplifies the vulkan code. - Implements resource management when vulkan window is minimized to allow resources to be freed.
Thanks for this, will this come to the official builds? |
@blackecos It's merged, so it's already in the official build. |
@dio-gh Just to be honest Im not sure thats the same thing here... I come from a link from this page: |
That's a build from before this PR was merged. This changeset is in master since |
Then should I go with the latest build -> wait for a crash and post some logs or something? x( |
This issue has been confirmed to be fixed. Your issue is most likely unrelated at all. Stop spamming github please, ask in Discord if you need further help. |
@blackecos I meant that what you are saying logically doesn't check out, and thus you're probably experiencing a different issue. By default, this would mean that you could/should open a new, separate issue, and post logs and issue description there. However, it'd be preferable if you visited our Discord server first as 13x says, and clarified that it's indeed a real issue, not a settings mishap or something. |
Fixes #5351