More warning fixes #6142
Merged
More warning fixes #6142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
Jun 28, 2019
elad335
reviewed
Jun 28, 2019
elad335
reviewed
Jun 28, 2019
elad335
reviewed
Jun 28, 2019
Megamouse
reviewed
Jun 28, 2019
Megamouse
reviewed
Jun 28, 2019
Megamouse
reviewed
Jun 28, 2019
Megamouse
reviewed
Jun 28, 2019
elad335
approved these changes
Jun 29, 2019
elad335
reviewed
Jun 29, 2019
elad335
reviewed
Jun 29, 2019
elad335
reviewed
Jun 29, 2019
elad335
approved these changes
Jun 30, 2019
These are technically UB but work just fine
- Fix a typo in OpenAL - Fix typo in cellHttp.h - Unused variables in catch - Use 64-bit shifts - Use use_count with shared pointers, unique is depracated and getting removed - Explicitly cast boolean to int - Signed/unsigned issues with loop variables - Fix missing return statement (the code path is unreachable, but compiler wants a return) - */ ouside of comment - Fix duplicate layout name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work started in #5964, but this time by using MSVC with CMake. Doesn't fix every warning but cleans up a lot of the mess that was being spat out by the compiler.