Fix Emu.Stop() with vulkan device enumeration hack #6190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
hack-fix
branch
3 times, most recently
from
f4f9b44
to
b22f482
Compare
This comment has been minimized.
This comment has been minimized.
elad335
changed the title
elad335
force-pushed
the
hack-fix
branch
4 times, most recently
from
5633868
to
75039de
Compare
|
Used a better solution |
|
What's the hurry with this one? Using new/delete is literally never justified in modern C++. I suspect it only needs a trivial detached thread. |
MSuih
reviewed
Jul 11, 2019
AniLeo
added
Render: Vulkan
Workaround
kd-11
reviewed
Jul 11, 2019
kd-11
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not attemp to join dev enumeration thread on Emu.Stop().