New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rsx::get_address report caller location #7345
Conversation
elad335
commented
Jan 30, 2020
•
edited
edited
- Report line and filename of caller rsx::get_address upon failure of address translation.
- Added verification for RSXIO REPORT memory for offsets out of range: offset must be lower than 10m.
- Fixes a regression in HLE cellGcmMapMainMemory from cellGcm HLE + sys_usbd: Add error_code #7266, minor cleanup.
Code is fine and logic is sound (and needed to aid debugging) but once again #7220 stands in the way. And no, its not about ease of fixing or correctness, think of it as a fence so that any bug reports after it will refer to builds created after it is resolved. That is the whole reasoning behind a code freeze. |
bd4c9b4
to
6245299
Compare
Use the pull request build, I don't need a log of master build. |
a1254a2
to
7619d7e
Compare
RSX no longer in maintaince mode merge it. 🎉 |
All review comments solved. |
Fix arguments order, softcode RsxReports::report offset.