Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum duration for audio buffering #8094

Merged
merged 1 commit into from Apr 25, 2020

Conversation

Jacoby1218
Copy link
Contributor

Fixes an issue addressed on discord for games at 60fps, where audio delay was introduced at the lowest duration (20ms). This changes the minimum duration to 0, fixing the audio delay in 60fps games.

@RainbowCookie32
Copy link
Contributor

Wouldn't disabling Audio buffering cause the same effect though?

@Jacoby1218
Copy link
Contributor Author

Would you rather this be 16.67ms? It would still solve the problem

@Jacoby1218
Copy link
Contributor Author

Changed the value to 4.1675ms (making this actually have an effect).

@Megamouse
Copy link
Contributor

you are only allowed to use whole numbers

@sampletext32
Copy link
Contributor

Consider making a squash for your changes

@Jacoby1218
Copy link
Contributor Author

Squashed, but it kept the original descriptions of each commit for some reason.

@sampletext32
Copy link
Contributor

Squashed, but it kept the original descriptions of each commit for some reason.

You can do the following to change commit description.

git commit --amend -m "New Message"
git push -f

In case you didn't know - first line is commit header, all others - description.
Consider changing description so it exactly points to what is done.

Oh, and BTW this PR says, that audio buffering minimum is set to 0, but in code you have like 4 ms. IMHO this is a mismatch. In case everything is desired to be like this - leave it, but in other case - change.

@Jacoby1218
Copy link
Contributor Author

ok just updated the title. thanks for the info!

@Nekotekina Nekotekina merged commit 72ab5f0 into RPCS3:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants