Various sys_net improvements & bugfixes #9065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RipleyTom
force-pushed
the
sys_net_improvements
branch
3 times, most recently
from
fa51ba8
to
e34c742
Compare
elad335
requested changes
Oct 13, 2020
| // windows doesn't support getsockname for sockets that are not bound | ||
| if (get_native_error() == 10022) | ||
| { | ||
| memset(&native_addr, 0, native_addrlen); |
There was a problem hiding this comment.
Horrible hack, you can just save it in IDM instead of the operating system I think.
There was a problem hiding this comment.
I agree that windows is a horrible hack but I don't understand what you want to save in IDM?
There was a problem hiding this comment.
sockname, dont rely on windows for it. unless it is expected to be empty for unbound sockets?
There was a problem hiding this comment.
yes it's expected to be 0.0.0.0:0 if unbound
elad335
reviewed
Oct 13, 2020
RipleyTom
force-pushed
the
sys_net_improvements
branch
from
e34c742
to
137fb56
Compare
|
Any thoughts on maybe consolidating the poll checks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.