Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Shaders cache fixes and optimizations #9530

Merged
merged 3 commits into from Jan 2, 2021
Merged

rsx: Shaders cache fixes and optimizations #9530

merged 3 commits into from Jan 2, 2021

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Jan 2, 2021 •
edited

Bugfixes

  • Fixed crash whenever files are missing from the cache.
  • Fixed crash whenever files are empty.
  • Fixed crash whenever file creation/overwrite of cache files failed. (handled by fs::write_file)
  • Fixed crash whenever there are any subdirectories inside the pipelines cache directories. (didnt check whether filesystem entry is a file or directory, treated directories as files)
  • Fixed shader cache of 2 or less pipelines.

Enhancements

  • Add some optimizations in compiling shaders. (move constructors, remove redundant copies of buffers, copy elision etc)
  • Overwrite invalid shader cache files if encountered such, restoring proper cache state and allowing the cache to be usable again.
  • Make FP shader data loading lock-free.

Fixes #9529

@MSuih MSuih requested a review from kd-11 January 2, 2021 05:21
@MSuih MSuih added the RSX label Jan 2, 2021
@elad335 elad335 force-pushed the rsx-shader branch 4 times, most recently from f681380 to 35057fa Compare January 2, 2021 05:58
@elad335
Copy link
Contributor Author

elad335 commented Jan 2, 2021

Fixed more filesystem bugs, added some optimization to quickly process RSX FP shaders critical section.

@elad335 elad335 force-pushed the rsx-shader branch 8 times, most recently from d7278a9 to c3d478c Compare January 2, 2021 07:20
@elad335
Copy link
Contributor Author

elad335 commented Jan 2, 2021

Fixed potential crash on the operation of saving shaders itself.

@elad335
Copy link
Contributor Author

elad335 commented Jan 2, 2021

Fix shader cache of 2 or less pipelines, funny bug but lets fix it.

Nekotekina
Nekotekina reviewed Jan 2, 2021
View reviewed changes
Utilities/File.h Outdated Show resolved Hide resolved
Nekotekina
Nekotekina reviewed Jan 2, 2021
View reviewed changes
Utilities/File.h Outdated Show resolved Hide resolved
@elad335 elad335 changed the title rsx: Fix creation of corrupted shaders rsx: Fix creation of corrupted shaders and optimizations Jan 2, 2021
@elad335
Copy link
Contributor Author

elad335 commented Jan 2, 2021

  • Make fp shader data loading lock-free.

kd-11
kd-11 reviewed Jan 2, 2021
View reviewed changes
rpcs3/Emu/RSX/rsx_cache.h Outdated Show resolved Hide resolved
@elad335 elad335 changed the title rsx: Fix creation of corrupted shaders and optimizations rsx: Shaders cache fixes and optimizations Jan 2, 2021
@elad335 elad335 force-pushed the rsx-shader branch 3 times, most recently from 03e7dde to 4dc4c65 Compare January 2, 2021 18:57
kd-11
kd-11 reviewed Jan 2, 2021
View reviewed changes
Utilities/File.h Outdated Show resolved Hide resolved
@elad335
rsx: Shaders cache loading and saving bugfixes
f56ec3e 
* Fixed crash whenever files are missing from the cache.
* Fixed crash whenever files are empty.
* Fixed crash whenever file creation/overwrite of cache files failed. (handled by fs::write_file)
* Fixed crash whenever there are any subdirectories inside the pipelines cache directories.
* Overwrite invalid shader cache files if encountered such.
* Optimizations have been added.
@elad335
rsx: Fix shader cache of 2 or less pipelines
f49dee9
@elad335
rsx: Make FP shader cache load lock-free
e6f1bb3
kd-11
kd-11 approved these changes Jan 2, 2021
View reviewed changes
Copy link
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kd-11 kd-11 merged commit 0e278d2 into RPCS3:master Jan 2, 2021
@AniLeo AniLeo mentioned this pull request Jan 3, 2021
Closed
@elad335 elad335 deleted the rsx-shader branch September 19, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nekotekina Nekotekina Nekotekina left review comments

@kd-11 kd-11 kd-11 approved these changes

Assignees
No one assigned
Labels
RSX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shader cache loading will fail if corrupted shader is encountered
4 participants
@elad335 @Nekotekina @kd-11 @MSuih