Make pad and patches config saving atomic

Utilities/Config.cpp

@@ -387,7 +387,7 @@ bool cfg::node::from_string(const std::string& value, bool dynamic)
 		return true;
 	}
 
-	cfg_log.fatal("Failed to load node: %s", error);
+	cfg_log.error("Failed to load node: %s", error);
 	return false;
 }
 

Utilities/File.h

@@ -45,7 +45,8 @@ namespace fs
 	constexpr auto lock    = +open_mode::lock; // Prevent opening the file more than once
 	constexpr auto unread  = +open_mode::unread; // Aggressively prevent reading the opened file (do not use)
 
-	constexpr auto rewrite = open_mode::write + open_mode::create + open_mode::trunc;
+	constexpr auto write_new = write + create + excl;
+	constexpr auto rewrite = write + create + trunc;
 
 	// File seek mode
 	enum class seek_mode : u32

Utilities/bin_patch.cpp

@@ -1064,13 +1064,6 @@ void patch_engine::save_config(const patch_map& patches_map)
 	const std::string path = get_patch_config_path();
 	patch_log.notice("Saving patch config file %s", path);
 
-	fs::file file(path, fs::rewrite);
-	if (!file)
-	{
-		patch_log.fatal("Failed to open patch config file %s (%s)", path, fs::g_tls_error);
-		return;
-	}
-
 	YAML::Emitter out;
 	out << YAML::BeginMap;
 
@@ -1134,7 +1127,12 @@ void patch_engine::save_config(const patch_map& patches_map)
 
 	out << YAML::EndMap;
 
-	file.write(out.c_str(), out.size());
+	fs::pending_file file(path);
+
+	if (!file.file || (file.file.write(out.c_str(), out.size()), !file.commit()))
+	{
+		patch_log.error("Failed to create patch config file %s (%s)", path, fs::g_tls_error);
+	}
 }
 
 static void append_patches(patch_engine::patch_map& existing_patches, const patch_engine::patch_map& new_patches, usz& count, usz& total, std::stringstream* log_messages)

rpcs3/Emu/Io/pad_config.cpp

@@ -68,11 +68,9 @@ void cfg_input::save(const std::string& title_id, const std::string& profile) co
 		input_log.fatal("Failed to create path: %s (%s)", cfg_name, fs::g_tls_error);
 	}
 
-	if (auto cfg_file = fs::file(cfg_name, fs::rewrite))
-	{
-		cfg_file.write(to_string());
-	}
-	else
+	fs::pending_file cfg_file(cfg_name);
+
+	if (!cfg_file.file || (cfg_file.file.write(to_string()), !cfg_file.commit()))
 	{
 		input_log.error("Failed to save pad config to '%s'", cfg_name);
 	}

rpcs3/rpcs3qt/patch_manager_dialog.cpp

@@ -982,11 +982,9 @@ bool patch_manager_dialog::handle_json(const QByteArray& data)
 		}
 
 		// Overwrite current patch file
-		if (fs::file patch_file = fs::file(path, fs::rewrite))
-		{
-			patch_file.write(content);
-		}
-		else
+		fs::pending_file patch_file(path);
+
+		if (!patch_file.file || (patch_file.file.write(content), !patch_file.commit()))
 		{
 			patch_log.error("Could not save new patches to %s (%s)", path, fs::g_tls_error);
 			return false;