Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Win32] Allow renaming uppercase RAP/EDAT to lowercase with drag-and-drop from /exdata #11048

Merged
merged 1 commit into from Oct 24, 2021
Merged

[Win32] Allow renaming uppercase RAP/EDAT to lowercase with drag-and-drop from /exdata #11048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 16 additions & 4 deletions rpcs3/rpcs3qt/main_window.cpp
View file
Open in desktop
Expand Up @@ -527,29 +527,41 @@ void main_window::BootRsxCapture(std::string path)

bool main_window::InstallFileInExData(const std::string& extension, const QString& path, const std::string& filename)
{
if (path.isEmpty() || filename.empty())
if (path.isEmpty() || filename.empty() || extension.empty())
{
return false;
}

// Copy file atomically with thread/process-safe error checking for file size

fs::pending_file to(rpcs3::utils::get_hdd0_dir() + "/home/" + Emu.GetUsr() + "/exdata/" + filename.substr(0, filename.find_last_of('.')) + "." + extension);
const fs::file from(sstr(path));
const std::string to_path = rpcs3::utils::get_hdd0_dir() + "/home/" + Emu.GetUsr() + "/exdata/" + filename.substr(0, filename.find_last_of('.'));
fs::pending_file to(to_path + "." + extension);
fs::file from(sstr(path));

if (!to.file || !from)
{
return false;
}

to.file.write(from.to_vector<u8>());
from.close();

if (to.file.size() < 0x10)
{
// Not a RAP file
return false;
}

#ifdef _WIN32
// In the case of an unexpected crash during the operation, the temporary file can be used as the deleted file
// See below
to.file.sync();

// In case we want to rename upper-case file to lower-case
// Windows will ignore such rename operation if the file exists
// So delete it
fs::remove_file(to_path + "." + fmt::to_upper(extension));
#endif

return to.commit();
}

Expand Down