Misc fixes

.ci/build-mac.sh

@@ -11,7 +11,7 @@ arch -x86_64 /usr/local/bin/brew reinstall -f --build-from-source ffmpeg gnutls
 arch -x86_64 /usr/local/bin/brew install llvm@16 glew cmake sdl2 vulkan-headers coreutils
 arch -x86_64 /usr/local/bin/brew link -f llvm@16
 
-# moltenvk based on commit for 1.2.5 release
+# moltenvk based on commit for 1.2.6 release
 wget https://raw.githubusercontent.com/Homebrew/homebrew-core/4ac0cfaca4c2505abe2fcbcc0ce5816572103a6c/Formula/m/molten-vk.rb
 arch -x86_64 /usr/local/bin/brew install -f --overwrite ./molten-vk.rb
 #export MACOSX_DEPLOYMENT_TARGET=12.0

rpcs3/Crypto/unzip.cpp

@@ -18,6 +18,10 @@ std::vector<u8> unzip(const void* src, usz size)
 #pragma GCC diagnostic ignored "-Wold-style-cast"
 #endif
 	int res = inflateInit2(&zs, 16 + 15);
+	if (res != Z_OK)
+	{
+		return {};
+	}
 #ifndef _MSC_VER
 #pragma GCC diagnostic pop
 #endif
@@ -79,6 +83,10 @@ bool unzip(const void* src, usz size, fs::file& out)
 #pragma GCC diagnostic ignored "-Wold-style-cast"
 #endif
 	int res = inflateInit(&strm);
+	if (res != Z_OK)
+	{
+		return false;
+	}
 #ifndef _MSC_VER
 #pragma GCC diagnostic pop
 #endif
@@ -138,6 +146,10 @@ std::vector<u8> zip(const void* src, usz size)
 #pragma GCC diagnostic ignored "-Wold-style-cast"
 #endif
 	int res = deflateInit2(&zs, 9, Z_DEFLATED, 16 + 15, 9, Z_DEFAULT_STRATEGY);
+	if (res != Z_OK)
+	{
+		return {};
+	}
 #ifndef _MSC_VER
 #pragma GCC diagnostic pop
 #endif

rpcs3/Emu/VFS.cpp

@@ -1054,7 +1054,7 @@ bool vfs::host::unlink(const std::string& path, [[maybe_unused]] const std::stri
 #endif
 }
 
-bool vfs::host::remove_all(const std::string& path, [[maybe_unused]] const std::string& dev_root, [[maybe_unused]] const lv2_fs_mount_point* mp, bool remove_root, bool lock)
+bool vfs::host::remove_all(const std::string& path, [[maybe_unused]] const std::string& dev_root, [[maybe_unused]] const lv2_fs_mount_point* mp, bool remove_root, [[maybe_unused]] bool lock)
 {
 #ifdef _WIN32
 	if (remove_root)

rpcs3/rpcs3qt/flow_layout.cpp

@@ -164,7 +164,7 @@ QSize flow_layout::sizeHint() const
 QSize flow_layout::minimumSize() const
 {
 	QSize size;
-	for (const QLayoutItem* item : qAsConst(itemList))
+	for (const QLayoutItem* item : itemList)
 	{
 		if (item)
 		{