Add error on missing 'override'

Utilities/JIT.h

@@ -177,6 +177,10 @@ inline FT build_function_asm(F&& builder)
 #pragma GCC diagnostic ignored "-Wall"
 #pragma GCC diagnostic ignored "-Wextra"
 #pragma GCC diagnostic ignored "-Wold-style-cast"
+#pragma GCC diagnostic ignored "-Wsuggest-override"
+#ifdef __clang__
+#pragma clang diagnostic ignored "-Winconsistent-missing-override"
+#endif
 #endif
 #include "llvm/IR/LLVMContext.h"
 #include "llvm/IR/Module.h"

rpcs3/Emu/Cell/PPCDisAsm.h

@@ -9,7 +9,7 @@ class PPCDisAsm : public CPUDisAsm
 	{
 	}
 
-	virtual u32 DisAsmBranchTarget(const s32 imm)=0;
+	virtual u32 DisAsmBranchTarget(const s32 imm) override = 0;
 
 	void DisAsm_V4(const std::string& op, u32 v0, u32 v1, u32 v2, u32 v3)
 	{

rpcs3/Emu/RSX/VK/VKCommonDecompiler.cpp

@@ -8,6 +8,10 @@
 #pragma GCC diagnostic ignored "-Wall"
 #pragma GCC diagnostic ignored "-Wextra"
 #pragma GCC diagnostic ignored "-Wold-style-cast"
+#pragma GCC diagnostic ignored "-Wsuggest-override"
+#ifdef __clang__
+#pragma clang diagnostic ignored "-Winconsistent-missing-override"
+#endif
 #endif
 #include "SPIRV/GlslangToSpv.h"
 #include "spirv-tools/optimizer.hpp"

rpcs3/Emu/RSX/VK/VKMemAlloc.cpp

@@ -43,6 +43,10 @@ class VmaRWMutex
 #pragma GCC diagnostic ignored "-Wextra"
 #pragma GCC diagnostic ignored "-Wold-style-cast"
 #pragma GCC diagnostic ignored "-Wunused-variable"
+#pragma GCC diagnostic ignored "-Wsuggest-override"
+#ifdef __clang__
+#pragma clang diagnostic ignored "-Winconsistent-missing-override"
+#endif
 #endif
 #include "3rdparty/GPUOpen/include/vk_mem_alloc.h"
 #ifdef _MSC_VER

rpcs3/cmake_modules/ConfigureCompiler.cmake

@@ -33,6 +33,12 @@ else()
 	add_compile_options(-Werror=return-type)
 	add_compile_options(-Werror=overloaded-virtual)
 
+	if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+		add_compile_options(-Werror=inconsistent-missing-override)
+	else()
+		add_compile_options(-Werror=suggest-override)
+	endif()
+
 	#TODO Clean the code so these are removed
 	add_compile_options(-Wno-attributes)
 

rpcs3/rpcs3qt/custom_table_widget_item.h

@@ -14,7 +14,7 @@ class custom_table_widget_item : public QTableWidgetItem
 	custom_table_widget_item(const std::string& text, int sort_role = Qt::DisplayRole, const QVariant& sort_value = 0);
 	custom_table_widget_item(const QString& text, int sort_role = Qt::DisplayRole, const QVariant& sort_value = 0);
 
-	bool operator<(const QTableWidgetItem& other) const;
+	bool operator<(const QTableWidgetItem& other) const override;
 
 	void setData(int role, const QVariant& value, bool assign_sort_role);
 };

rpcs3/rpcs3qt/log_frame.cpp

@@ -51,7 +51,7 @@ struct gui_listener : logs::listener
 	{
 	}
 
-	void log(u64 stamp, const logs::message& msg, const std::string& prefix, const std::string& text)
+	void log(u64 stamp, const logs::message& msg, const std::string& prefix, const std::string& text) override
 	{
 		Q_UNUSED(stamp);