Ambush choke in combat #2378
Ambush choke in combat #2378
Conversation
|
Could you add this to https://github.com/rpherbig/dr-scripts/blob/master/validate.lic#L344 ? |
combat-trainer.lic
Outdated
| 'dumping some dirt', 'What were you referring') | ||
| end | ||
|
|
||
| false |
There was a problem hiding this comment.
I realize you're following the precedent of the other training abilities, but I'm not convinced the return value is used anywhere. What do you think?
There was a problem hiding this comment.
You'd need a return up in the case that calls this like ambush_stun has, but that's only necessary if the action here could cause a real change in game state, I don't think choke can kill mobs so there's no need.
There was a problem hiding this comment.
You're right, totally not needed. Removed.
| @@ -0,0 +1,31 @@ | |||
| custom_require.call(%w[common common-items drinfomon]) | |||
There was a problem hiding this comment.
Do you plan to document this on elanthipedia?
There was a problem hiding this comment.
Sure, I can do that!
There was a problem hiding this comment.
Can you add a header documentation block to the script?
fill-dirt.lic
Outdated
|
|
||
| def fill_stacker | ||
| loop do | ||
| forage?('dirt') |
There was a problem hiding this comment.
Do you want to break if forage? fails?
There was a problem hiding this comment.
Good idea; done.
(Plus a script for filling a dirt stacker)