Add New Dissect #5150
Merged
Add New Dissect #5150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate from Necro ritual dissect, more closely tied to skinning and available to everyone. Has been tested by quite a few folks and this is the best usage I can achieve with the Simu-side syntax being super wonky. Koror said they'll look at the targeting so we may have updates in coming days but people are very anxious to get started and this is functional for current conditions.
rpherbig
reviewed
Sep 1, 2021
| def check_skinning(mob_noun, game_state) | ||
| if @dissect && game_state.dissectable?(mob_noun) | ||
| if @dissect_priority == 'First Aid' && DRSkill.getxp('First Aid') <= 32 |
There was a problem hiding this comment.
💡 You might want to add a validator that dissect_priority is only one of those two strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate from Necro ritual dissect, more closely tied to skinning and available to everyone. Has been tested by quite a few folks and this is the best usage I can achieve with the Simu-side syntax being super wonky. Koror said they'll look at the targeting so we may have updates in coming days but people are very anxious to get started and this is functional for current conditions.