Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RPMPackageMetadata::parse() and RPMPackageMetadata::open() public #140

Merged
merged 1 commit into from
May 16, 2023
Merged

Make RPMPackageMetadata::parse() and RPMPackageMetadata::open() public #140

merged 1 commit into from
May 16, 2023

Conversation

dralley
Copy link
Collaborator

@dralley dralley commented May 16, 2023

If all you want is a quick way to read the package metadata, this works and saves time and memory.

📜 Checklist

  • Commits are cleanly separated and have useful messages
  • A changelog entry or entries has been added to CHANGELOG.md
  • Documentation is thorough
  • Test coverage is excellent and passes
  • Works when tests are run --all-features enabled

@dralley
Make RPMPackageMetadata::parse() and RPMPackageMetadata::open() public
f7943fd 
If all you want is a quick way to read the package metadata, this works
and saves time and memory.
@dralley dralley requested a review from cmeister2 May 16, 2023 14:20
@dralley
Copy link
Collaborator Author

dralley commented May 16, 2023

@ikrivosheev

@dralley dralley requested a review from drahnr May 16, 2023 14:24
ikrivosheev
ikrivosheev approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dralley LGTM! Thank you)

maxdymond
maxdymond approved these changes May 16, 2023 •
edited
Loading
View reviewed changes
@cmeister2
Copy link
Collaborator

I really need to stop doing that :) LGTM.

@dralley dralley merged commit cb5ef9c into rpm-rs:master May 16, 2023
@dralley dralley deleted the metadata branch May 16, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmeister2 cmeister2 cmeister2 approved these changes

@ikrivosheev ikrivosheev ikrivosheev approved these changes

@maxdymond maxdymond maxdymond approved these changes

@drahnr drahnr Awaiting requested review from drahnr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dralley @cmeister2 @ikrivosheev @maxdymond