Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 6 test scenarios for deplist #183

Merged
merged 1 commit into from Oct 24, 2016

Conversation

j-mracek
Copy link
Member

  • Enhance of ci-dnf-stack


Scenario: Deplist with --latest-limit and verbose
When I execute "dnf" command "repoquery --deplist --latest-limit 1 --verbose TestA" with "success"
Then line from "stdout" should "start" with "package: TestA-1.0.0-2.noarch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you use same comparison as above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impossible with verbose mode

Feature: Deplist as commmand and option

Scenario: Feature Setup
Given I use the repository "upgrade_1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use generation on the fly? this would help visibility.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less work and now idea how to setup more complicate repo, with versions, and requires. Pity that you pushed the changes, because they are not mature.

@ignatenkobrain
Copy link
Contributor

Actually I removed 2 lines + added @xfail as currently it fails.

About 2 lines - it's bug somewhere in ur PR for DNF. After last package it should not print extra newline.

@j-mracek
Copy link
Member Author

@ignatenkobrain Fixed @xfail now you can merge it.

@j-mracek
Copy link
Member Author

@ignatenkobrain Please can you merge it, it was refactored.

@ignatenkobrain
Copy link
Contributor

split this PR and that bit from #182

@j-mracek
Copy link
Member Author

@ignatenkobrain Done

@mhatina
Copy link

mhatina commented Oct 20, 2016

@dnf-bot r+

@mhatina mhatina merged commit cac5697 into rpm-software-management:master Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants