Add option --deplist for repoquery #621

j-mracek · 2016-09-23T08:23:52Z

It also allows to run it as command 'dnf deplist ' - yum compatibility.

I will provide test for CI-dnf-stack

mhatina

Looks good to me.

mhatina · 2016-10-03T12:08:17Z

Waiting for tests to be merged (rpm-software-management/ci-dnf-stack#183).

mluscon · 2016-10-10T21:01:46Z

dnf/cli/commands/repoquery.py

@@ -90,7 +90,7 @@ class RepoQueryCommand(commands.Command):
    """A class containing methods needed by the cli to execute the repoquery command.
    """

-    aliases = ('repoquery',)
+    aliases = ('repoquery', 'deplist')


Should not this belong to yum-dnf wrapper @jsilhan?

@j-mracek , has yum repoquery really --deplist option? If so then it would be easier to have it here otherwise it should be rather another command file. I don't know if architecture of yum wrapper allows adding custom commands. Does it, @mhatina ?

@jsilhan repoquery (yum-utils) do not have option --deplist.
The solution here allows hidden compatibility with "yum deplist", but it has all functionality of repoquery therefore it allows all options for package filtrating, but no additional lines of code were required. Somehow the new option for repoguery sounds better to me (with more functionality) than new command (require more code). The solution still keeps 100% compatibility with 'yum deplist'.

@mhatina Please the PR requires your opinion from jsilhan question.

@jsilhan It does now. (Sorry for late response, I have to modify my filters in gmail)

@jsilhan @j-mracek Do we have a solution for this? Will it be implemented using yum wrapper?

dnf-bot · 2016-11-08T13:46:21Z

dnf/cli/commands/repoquery.py

@@ -120,6 +120,8 @@ def set_argparser(parser):
                                      help=_("check non-explicit dependencies (files and Provides); default"))
        whatrequiresform.add_argument("--exactdeps", action="store_true",
                                      help=_('check dependencies exactly as given, opposite of --alldeps'))
+        parser.add_argument('--deplist', action='store_true',
+                            help=_("list of all dependencies and what packages it provides"))


[flake8]

[E501] line too long (93 > 79 characters)

j-mracek · 2016-11-08T14:06:35Z

doc/cli_vs_yum.rst

-===========================
- No ``deplist`` command
-===========================
-


Here I am not sure if it should be deleted. Command yum deplist will works but not dnf deplist. For dnf you have to use dnf repoquery --deplist. @jsilhan Is that what was supposed to? And how to handle descriptions in cli_vs_yum.rst ?

FTR cli_vs_yum is documentation of differences of upstream DNF project and yum (yum-deprecated). So in this case it should be there as a change although there should be some .. seealso:: mentioning the command exists in yum-dnf when /usr/bin/yum is executed.

j-mracek · 2016-11-09T14:26:16Z

test this please

mhatina · 2016-11-11T13:31:03Z

@dnf-bot retest this please

j-mracek · 2016-11-11T21:48:36Z

test this please

j-mracek · 2016-11-14T14:02:19Z

test this please

dnf-bot · 2016-11-21T10:54:26Z

📌 Commit de287cf has been approved by mhatina

dnf-bot · 2016-11-21T11:37:50Z

⌛ Testing commit de287cf with merge 03277ce...

Closes: #621 Approved by: mhatina

dnf-bot · 2016-11-21T12:21:47Z

☀️ Test successful - status-jenkins
Approved by: mhatina
Pushing 03277ce to master...

keszybz · 2016-11-21T14:27:34Z

dnf/yum/commands/deplist.py

+    """
+
+    aliases = ('deplist',)
+    summary = _("List a package's dependencies")


This is not grammatical. Should be "List packages' dependencies".

It is grammatically correct. It just lists dependencies of one package and what you suggested lists dependencies of more packages.

Singular: "List package's dependencies", plural: "List packages' dependencies". Pick one.

keszybz · 2016-11-21T14:27:39Z

dnf/yum/commands/deplist.py

+
+class DeplistCommand(RepoQueryCommand):
+    """
+    some comment about command


Yes, I missed that in review.

keszybz · 2016-11-21T14:28:06Z

dnf/cli/commands/repoquery.py

@@ -120,6 +120,8 @@ def set_argparser(parser):
                                      help=_("check non-explicit dependencies (files and Provides); default"))
        whatrequiresform.add_argument("--exactdeps", action="store_true",
                                      help=_('check dependencies exactly as given, opposite of --alldeps'))
+        parser.add_argument('--deplist', action='store_true', help=_(
+            "list of all dependencies and what packages it provides"))


This sentence makes not sense ;(

It does make sense. It lists all dependencies and for each dependency lists packages that provide given dependency.

Maybe it could be changed, so it is easily understandable.

"It" refers to "list" ("list" is the subject of the sentence). But a "list" does not "provide" packages. I'm not sure what exactly the sentence was supposed to convey, so I don't know how to fix it, but it needs to be changed.

mluscon · 2016-11-21T14:45:01Z

@j-mracek, take a second look please.

j-mracek · 2016-11-22T07:59:00Z

@mhatina @keszybz Here is the patch that change descriptions. Thank you very much for notes the problem.

mhatina · 2016-11-22T08:26:58Z

@dnf-bot r+

dnf-bot · 2016-11-22T08:26:59Z

📌 Commit 22a6c17 has been approved by mhatina

dnf-bot · 2016-11-22T08:27:05Z

⌛ Testing commit 22a6c17 with merge 88a8e46...

Closes: #621 Approved by: mhatina

dnf-bot · 2016-11-22T09:24:44Z

💔 Test failed - status-jenkins

ignatenkobrain · 2016-11-22T10:53:59Z

@dnf-bot retry

dnf-bot · 2016-11-22T10:54:08Z

⌛ Testing commit 22a6c17 with merge 7b7950a...

Closes: #621 Approved by: mhatina

dnf-bot · 2016-11-22T11:38:19Z

💔 Test failed - status-jenkins

keszybz · 2016-11-22T13:23:29Z

dnf/cli/commands/repoquery.py

@@ -121,7 +121,7 @@ def set_argparser(parser):
        whatrequiresform.add_argument("--exactdeps", action="store_true",
                                      help=_('check dependencies exactly as given, opposite of --alldeps'))
        parser.add_argument('--deplist', action='store_true', help=_(
-            "list of all dependencies and what packages it provides"))
+            "show a list of all dependencies and what packages provide it"))


This version is better, thanks. "provide them" would be better.

@keszybz Thanks for corrections, I just overlooked the text (too much inspiration from yum)

j-mracek · 2016-11-22T13:51:08Z

@dnf-bot r+

dnf-bot · 2016-11-22T13:51:10Z

📌 Commit e53c234 has been approved by j-mracek

dnf-bot · 2016-11-22T13:51:21Z

⌛ Testing commit e53c234 with merge d6efe72...

dnf-bot · 2016-11-22T14:53:58Z

☀️ Test successful - status-jenkins
Approved by: j-mracek
Pushing d6efe72 to master...

j-mracek force-pushed the deplist branch 2 times, most recently from d1efaa4 to 40f6de1 Compare September 23, 2016 12:54

mluscon added the ready for review label Sep 26, 2016

mluscon assigned mluscon and mhatina Sep 26, 2016

mhatina approved these changes Sep 29, 2016

View reviewed changes

mhatina added blocked test_needed and removed ready for review approved labels Oct 10, 2016

mluscon reviewed Oct 10, 2016

View reviewed changes

j-mracek removed the test_needed label Oct 21, 2016

mluscon added refactor_needed and removed blocked labels Oct 26, 2016

mhatina added the question label Nov 7, 2016

j-mracek force-pushed the deplist branch from f2f30b6 to 3c03aed Compare November 8, 2016 13:46

dnf-bot reviewed Nov 8, 2016

View reviewed changes

j-mracek force-pushed the deplist branch 2 times, most recently from 1827871 to 393b041 Compare November 8, 2016 14:00

j-mracek commented Nov 8, 2016

View reviewed changes

j-mracek added ready for review and removed refactor_needed labels Nov 8, 2016

j-mracek force-pushed the deplist branch from 393b041 to 309a438 Compare November 9, 2016 13:40

j-mracek removed the question label Nov 9, 2016

dnf-bot pushed a commit that referenced this pull request Nov 21, 2016

Change yum-vs-dnf documentation for deplist

ee25f65

Closes: #621 Approved by: mhatina

dnf-bot pushed a commit that referenced this pull request Nov 21, 2016

Change incorrect information about repoquery and formating

03277ce

Closes: #621 Approved by: mhatina

dnf-bot closed this in fea4c74 Nov 21, 2016

keszybz reviewed Nov 21, 2016

View reviewed changes

mluscon reopened this Nov 21, 2016

Fix description of deplist option and command

22a6c17

j-mracek force-pushed the deplist branch from 10cea4e to 22a6c17 Compare November 22, 2016 07:57

dnf-bot pushed a commit that referenced this pull request Nov 22, 2016

Fix description of deplist option and command

88a8e46

Closes: #621 Approved by: mhatina

dnf-bot pushed a commit that referenced this pull request Nov 22, 2016

Fix description of deplist option and command

7b7950a

Closes: #621 Approved by: mhatina

keszybz reviewed Nov 22, 2016

View reviewed changes

fixup! Fix description of deplist option and command

e53c234

dnf-bot closed this in d6efe72 Nov 22, 2016

Add option --deplist for repoquery #621

Add option --deplist for repoquery #621

Conversation

j-mracek commented Sep 23, 2016

mhatina left a comment

Choose a reason for hiding this comment

mhatina commented Oct 3, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

j-mracek commented Nov 9, 2016

mhatina commented Nov 11, 2016

j-mracek commented Nov 11, 2016

j-mracek commented Nov 14, 2016

dnf-bot commented Nov 21, 2016

dnf-bot commented Nov 21, 2016

dnf-bot commented Nov 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhatina Nov 21, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mluscon commented Nov 21, 2016

j-mracek commented Nov 22, 2016

mhatina commented Nov 22, 2016

dnf-bot commented Nov 22, 2016

dnf-bot commented Nov 22, 2016

dnf-bot commented Nov 22, 2016

ignatenkobrain commented Nov 22, 2016

dnf-bot commented Nov 22, 2016

dnf-bot commented Nov 22, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

j-mracek commented Nov 22, 2016

dnf-bot commented Nov 22, 2016

dnf-bot commented Nov 22, 2016

dnf-bot commented Nov 22, 2016

mhatina Nov 21, 2016 •

edited