Tests for check --dependencies and repoquery --requires-pre with %pre and %post #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukash
reviewed
Oct 29, 2019
|
|
||
| @bz1543449 | ||
| Scenario: Removed scriptlet pre and post dependencies are not reported as missing | ||
| Given I use repository "dnf-ci-check-dependencies" |
There was a problem hiding this comment.
AFAIK the names of repositories that belong to single feature files so far don't have the "dnf-ci-" prefix, so let's keep it consistent? (and name the repository just check-dependencies?)
On a side note, I'm still worried it's becoming a bit of a mess, that's why I wanted to agree on some rules a while ago...
There was a problem hiding this comment.
I see, I have updated it to check-dependencies.
Thanks.
I agree, it confused me at least.
kontura
force-pushed
the
test_requires_pre
branch
from
f20c094
to
a6f9869
Compare
kontura
force-pushed
the
test_requires_pre
branch
from
a6f9869
to
035661b
Compare
kontura
force-pushed
the
test_requires_pre
branch
from
035661b
to
88390ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers:
rpm-software-management/dnf#1512
rpm-software-management/libdnf#827
I created separate packages for the check --dependencies and repoquery tests.