Check should not report missing %pre and %post deps (RhBug:1543449) #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest that overloading requires_pre is not good idea. |
kontura
added
ready for review
work in progress
and removed
changes requested
ready for review
labels
|
☔ The latest upstream changes (presumably 5ccde9f) made this pull request unmergeable. Please resolve the merge conflicts. |
kontura
force-pushed
the
requires_pre
branch
from
928f9fe
to
c2876e9
Compare
|
There was an error while running a copr build: You can re-trigger build by adding a comment ( |
|
📌 Commit ed3987f has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 5, 2020
https://bugzilla.redhat.com/show_bug.cgi?id=1543449 Closes: #1512 Approved by: j-mracek
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 5, 2020
Closes: #1512 Approved by: j-mracek
|
💔 Test failed - status-papr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1543449
This depends on rpm-software-management/libdnf#827