Test logfile permissions (RhBug:1910084)

[pkratoch]

Tests for rpm-software-management/dnf#1714

[kontura]

I have just one suggestion, it would make sense to me to test that rotating the logs also respects umask. I think this could be achieved by setting dnf conf log_size to some really small value so that it rotates right away for the first command, maybe 1k?

Other than that LGTM. 🙂

[pkratoch]

Thanks for the review and the suggestion of new test!

There was actually another bug - the new dnf.rpm.log was sometimes created with mode 644 because rpm is setting umask during a transaction run.

I think that the best behavior is not to respect umask during the log rotation, but keep the same mode as the old log. This also means that user can change permissions of the base log file and it will be respected further on.

So, here is the dnf PR: rpm-software-management/dnf#1736

And I added test that log rotation preserves the log file permissions.

[kontura]

That is great, thanks!

Tests pass.