Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reposync] Add --urls option (RhBug:1686602) #346

Merged
merged 7 commits into from Nov 8, 2019

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented Jul 12, 2019

This is compatibility with yum-utils version of the reposync.
When the --urls switch is used, packages are not downloaded from
repositories, only their URLs are printed.

https://bugzilla.redhat.com/show_bug.cgi?id=1686602

@m-blaha
Copy link
Member Author

m-blaha commented Jul 12, 2019

Corresponding test: rpm-software-management/ci-dnf-stack#575

@pkratoch pkratoch self-assigned this Jul 15, 2019
@jamescassell
Copy link

jamescassell commented Jul 20, 2019

Would be great if this also printed the metadata URLs when --download-metadata is passed, rather than the behavior of printing the URLs for packages, but downloading the metadata.

edit: I'd expect that using the --urls option would change nothing on disk and only print out URLs to what is normally downloaded.

@jamescassell
Copy link

Also, this seems to output rsync:// URLs on Fedora default repos, which is likely not what dnf would use to download the objects.

@m-blaha
Copy link
Member Author

m-blaha commented Jul 23, 2019

@jamescassell I added commit to not use rsync:// urls in --urls output.

@m-blaha
Copy link
Member Author

m-blaha commented Aug 9, 2019

plugins/reposync.py Outdated Show resolved Hide resolved
@rh-atomic-bot
Copy link

☔ The latest upstream changes (presumably e26b194) made this pull request unmergeable. Please resolve the merge conflicts.

@rh-atomic-bot
Copy link

☔ The latest upstream changes (presumably 549e0f4) made this pull request unmergeable. Please resolve the merge conflicts.

Do deleting of stale packages outside of download_packages() function.
This is compatibility with yum-utils version of the reposync.
When the --urls switch is used, packages are not downloaded from
repositories, only their URLs are printed.

https://bugzilla.redhat.com/show_bug.cgi?id=1686602
Drop special handling of packages from local repositories - do the
downloading using librepo as if they were remotes.
The advantage is unified output of reposync regardless the location of
the repository. Without this patch packages from the local repositories
are just silently copied to the destination without notifying the user.
Do not print rsync:// urls when reposync is run with --urls switch.
@pkratoch pkratoch merged commit 5e57fa3 into rpm-software-management:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants