Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Method to get all repository metadata locations #770

Merged
merged 1 commit into from Oct 24, 2019

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented Aug 9, 2019

Needed so that command "dnf reposync --urls --download-metadata" was
able to print out also URLs of the repository metadata.

Copy link
Contributor

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding it!

@j-mracek
Copy link
Member

j-mracek commented Sep 9, 2019

@rh-atomic-bot try

@rh-atomic-bot
Copy link

⌛ Trying commit e2e15c0 with merge 2a273c6...

rh-atomic-bot pushed a commit that referenced this pull request Sep 9, 2019
Needed so that command "dnf reposync --urls --download-metadata" was
able to print out also URLs of the repository metadata.

Closes: #770
Approved by: <try>
@rh-atomic-bot
Copy link

💥 Test timed out

@j-mracek
Copy link
Member

@rh-atomic-bot r+

@rh-atomic-bot
Copy link

📌 Commit e2e15c0 has been approved by j-mracek

@j-mracek
Copy link
Member

@rh-atomic-bot r-

@packit-as-a-service
Copy link

There was an error while running a copr build: (0)
Reason:

You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

@j-mracek
Copy link
Member

@rh-atomic-bot r+

@rh-atomic-bot
Copy link

📌 Commit 74a713c has been approved by j-mracek

@rh-atomic-bot
Copy link

⌛ Testing commit 74a713c with merge 53efe2e...

rh-atomic-bot pushed a commit that referenced this pull request Sep 24, 2019
Needed so that command "dnf reposync --urls --download-metadata" was
able to print out also URLs of the repository metadata.

Closes: #770
Approved by: j-mracek
@rh-atomic-bot
Copy link

💥 Test timed out

@j-mracek
Copy link
Member

j-mracek commented Oct 8, 2019

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit 74a713c with merge 2d312e0...

rh-atomic-bot pushed a commit that referenced this pull request Oct 8, 2019
Needed so that command "dnf reposync --urls --download-metadata" was
able to print out also URLs of the repository metadata.

Closes: #770
Approved by: j-mracek
@rh-atomic-bot
Copy link

💔 Test failed - status-papr

@pkratoch
Copy link
Contributor

pkratoch commented Oct 8, 2019

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit 74a713c with merge 7b83226...

rh-atomic-bot pushed a commit that referenced this pull request Oct 8, 2019
Needed so that command "dnf reposync --urls --download-metadata" was
able to print out also URLs of the repository metadata.

Closes: #770
Approved by: j-mracek
@rh-atomic-bot
Copy link

💔 Test failed - status-papr

@j-mracek
Copy link
Member

j-mracek commented Oct 8, 2019

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit 74a713c with merge 1d8d049...

rh-atomic-bot pushed a commit that referenced this pull request Oct 8, 2019
Needed so that command "dnf reposync --urls --download-metadata" was
able to print out also URLs of the repository metadata.

Closes: #770
Approved by: j-mracek
@rh-atomic-bot
Copy link

💔 Test failed - status-papr

@dmnks
Copy link
Contributor

dmnks commented Oct 9, 2019

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit 74a713c with merge ea49896...

rh-atomic-bot pushed a commit that referenced this pull request Oct 9, 2019
Needed so that command "dnf reposync --urls --download-metadata" was
able to print out also URLs of the repository metadata.

Closes: #770
Approved by: j-mracek
@dmnks
Copy link
Contributor

dmnks commented Oct 9, 2019

OK, so the reason for the CI failure is that the internal minor version number in libdnf differs from the one in the spec file.

The test that's failing is looking at the User-Agent header libdnf/0.35.5 returned by libdnf and compares it with the libdnf version taken from the rpmdb (which is 0.35.6).

@m-blaha Could you please rebase this PR and bump the internal version to 6?

@rh-atomic-bot
Copy link

💔 Test failed - status-papr

@m-blaha
Copy link
Member Author

m-blaha commented Oct 11, 2019

@dmnks Done

@dmnks
Copy link
Contributor

dmnks commented Oct 11, 2019

@rh-atomic-bot retry

@packit-as-a-service
Copy link

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/rpm-software-management-libdnf-770
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@rh-atomic-bot
Copy link

☔ The latest upstream changes (presumably 0999bcc) made this pull request unmergeable. Please resolve the merge conflicts.

@pkratoch
Copy link
Contributor

@rh-atomic-bot retry

@m-blaha
Copy link
Member Author

m-blaha commented Oct 24, 2019

@rh-atomic-bot r+

@rh-atomic-bot
Copy link

📌 Commit 1d9bb42 has been approved by m-blaha

rh-atomic-bot pushed a commit that referenced this pull request Oct 24, 2019
Needed so that command "dnf reposync --urls --download-metadata" was
able to print out also URLs of the repository metadata.

Closes: #770
Approved by: m-blaha
@rh-atomic-bot
Copy link

⌛ Testing commit 1d9bb42 with merge b476a69...

@rh-atomic-bot
Copy link

☀️ Test successful - status-papr
Approved by: m-blaha
Pushing b476a69 to master...

@rh-atomic-bot
Copy link

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

Needed so that command "dnf reposync --urls --download-metadata" was
able to print out also URLs of the repository metadata.
@j-mracek j-mracek merged commit 456d905 into rpm-software-management:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants