[system-upgrade] Save module_platform_id config option #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is module platform ID divined when someone passes just the releasever? Because it gets tricky figuring this out since releasever and platform ID are not the same value. |
|
The code looks fine. |
https://bugzilla.redhat.com/show_bug.cgi?id=1656509 Option module_platform_id is necessary to perform a system upgrade and switch to a new platform.
pkratoch
force-pushed
the
module_platform_id
branch
from
9188b41
to
2b0074b
Compare
|
@Conan-Kudo I completely agree with you. But we cannot format platform id automatically because the format of platform ID is undefined, therefore valid platform id is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option module_platform_id is necessary to perform a system upgrade and switch to
a new platform.