Add warn to ensure that system is fully upgraded (RhBug:1225442) #97
Conversation
doc/system-upgrade.rst
Outdated
| release. It replaces fedup (the old Fedora Upgrade tool). | ||
|
|
||
| release. It replaces fedup (the old Fedora Upgrade tool). Before you proceed ensure that your system | ||
| is fully upgraded (``dnf upgrade --refresh``). |
There was a problem hiding this comment.
It should be dnf --refresh upgrade. Technically the order doesn't matter, but that's how the man page displays it, so we should be consistent.
plugins/system_upgrade.py
Outdated
| @@ -345,6 +345,8 @@ def _call_sub(self, name, *args): | |||
| # == configure_*: set up action-specific demands ========================== | |||
|
|
|||
| def configure_download(self, *args): | |||
| msg = _('Please ensure that your system is fully upgraded!') | |||
| logger.warning(self.base.output.term.bold(msg) + ' ("dnf upgrade --refresh")') | |||
doc/system-upgrade.rst
Outdated
| @@ -111,6 +111,8 @@ Examples | |||
| Typical upgrade usage | |||
| --------------------- | |||
|
|
|||
| ``dnf upgrade --refresh`` | |||
|
I would like to add some commits |
|
I am going to remove some lines |
j-mracek
force-pushed
the
system-upgrade
branch
2 times, most recently
from
f6a9f05
to
4694e64
Compare
|
There is one disadvantage of the approach presented here, if anyone runs successful transaction after download, system upgrade will loose cached files and transaction will fail during reboot. |
plugins/rpm_conf.py
Outdated
|
|
||
| import dnf | ||
| from rpmconf import rpmconf | ||
| import errno | ||
| import sys |
There was a problem hiding this comment.
Change the import order according to PEP-8:
system imports, 3rd party library imports, project imports
plugins/system_upgrade.py
Outdated
| os.unlink(fullpath) | ||
| except OSError: | ||
| pass | ||
| if os.path.isdir(path): |
There was a problem hiding this comment.
The code is fine, but I'd rather do:
if not os.path.isdir(path):
return
<remaining code>
plugins/system_upgrade.py
Outdated
| def configure_download(self): | ||
| if self.base._promptWanted(): | ||
| msg = _('Do not continue unless your system is fully upgraded ' | ||
| '("dnf --refresh upgrade")! Do you want to continue') |
There was a problem hiding this comment.
Maybe improve the message? :
Before you continue, make sure your system is fully upgraded by running "dnf --refresh upgrade".
Do you want to continue?
plugins/snapper.py
Outdated
| import dnf | ||
| import dnfpluginsextras | ||
| import sys | ||
|
|
plugins/system_upgrade.py
Outdated
| from dnf.cli import CliError | ||
|
|
||
| import json | ||
| import os | ||
| import uuid | ||
|
|
plugins/torproxy.py
Outdated
| @@ -17,16 +17,15 @@ | |||
| # License and may only be used or replicated with the express permission of | |||
| # Red Hat, Inc. | |||
| # | |||
| from dnfpluginsextras import _, logger | |||
|
|
|||
plugins/tracer.py
Outdated
| @@ -21,16 +21,15 @@ | |||
| # | |||
|
|
|||
| from __future__ import absolute_import | |||
| from dnfpluginsextras import _ | |||
| from tracer import Query, Package | |||
| from tracer.views.default import DefaultView | |||
|
@dmach Here is an improved version |
It should help user to realize that there could be an issue when system is not fully upgraded. The patch also enhance the documentation. https://bugzilla.redhat.com/show_bug.cgi?id=1225442
It reflects that system-upgrade is plugin of extras.
After system-upgrade packages will not originate from @@commandline and local repositories will be fully available. https://bugzilla.redhat.com/show_bug.cgi?id=1387136 https://bugzilla.redhat.com/show_bug.cgi?id=1324151
The former behavior of system-upgrade installs all packages from given directory, but it looses information about origin of packages. The present behavior uses directly cached packages in repo, that also allows to use local repositories. Unfortunately the problems remains with usage of --datadir option and cannot be fixed, therefore it will be better to not use it at all. The option --datadir is also redundant with conf option to redirect of dnf cache.
|
I've reviewed the code and it looks good to me. Merging. |
It should help user to realize that there could be an issue when system is not
fully upgraded.
The patch also enhance the documentation.
https://bugzilla.redhat.com/show_bug.cgi?id=1225442
Requires: rpm-software-management/dnf#841