Catch TypeError for int(None) (RhBug:1597005)

[j-mracek]

In some cases "/proc/self/loginuid" could be not present, therefore it
contains None. The conversion to int returns not a ValueError but
TypeError.

https://bugzilla.redhat.com/show_bug.cgi?id=1597005

[m-blaha]

I do not think this is correct. When you try to open non-existent file, Python will raise IOError (or its more specific subclass FileNotFoundError in the case of python3). So the int(data) line is never executed.

I downloaded and run in qemu the risc image mentioned in the bz and found this:

# rpm -q dnf
dnf-2.7.5-8.fc28.noarch

# grep -A11 'def _getloginuid' /usr/lib/python3.6/site-packages/dnf/yum/misc.py 
def _getloginuid():
    """ Get the audit-uid/login-uid, if available. None is returned if there
        was a problem. Note that no caching is done here. """
    #  We might normally call audit.audit_getloginuid(), except that requires
    # importing all of the audit module. And it doesn't work anyway: BZ 518721
    try:
        with open("/proc/self/loginuid") as fo:
            data = fo.read()
            return int(data)
    except (IOError, ValueError):
        return None

The version of dnf used on risc is too old and is missing the fallback to os.getuid() introduced by commit 70779df

[j-mracek]

Thanks a lot for comment. Good point.