Improve command emmitter in dnf-automatic #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ignatenkobrain, @rhn As the people involved in #635 maybe you could review this PR? |
|
From the point of view of someone no longer knowing the codebase intimately, this looks fine. The What's still missing is the conf section, like this: https://github.com/rpm-software-management/dnf/pull/635/files#diff-d7fc665d559dc9ef30fccc4b33200a13R51 |
|
@rhn Thanks for you comment, but unfortunately I didn't get it. The aforementioned |
|
Somehow I didn't notice that the section already exists. Never mind. |
|
Seems to work 🙂 Thanks and sorry about the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why, but #635 seems to miss some code which prevents the usage of the Command emitter in dnf-automatic. They could be some code lost on rebase or something, but trying to make it work on my system, it turned out the following changes are required.
There are still some things which could be improved (such as explaining why
output.list_transaction(trans, total_width=80)still generates output with 120 characters, but it's outside the scope of that PR which just makes the command emmiter possible to use.Btw, I'm not a Python programmer, so please tell me if there is something done in the non idiomatic way.