Add dnf option --noclean (RhBug:1361424) #867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnf/cli/option_parser.py
Outdated
| @@ -262,6 +262,9 @@ def _main_parser(self): | |||
| metavar='[repo,path]', | |||
| help=_("label and path to additional repository," | |||
| " can be specified multiple times.")) | |||
| main_parser.add_argument("--noclean", action="store_false", | |||
There was a problem hiding this comment.
I think better option name would be --no-autoremove
|
Cleaning is very vague term |
|
It could be --noautoremove like --nogpgcheck |
|
@j-mracek fine with me |
The option sets clean_requirements_on_remove to false from commandline. The cleaning is pretty strong behavior that is handy to be easily be switched off. https://bugzilla.redhat.com/show_bug.cgi?id=1361424
|
@dnf-bot r+ |
|
📌 Commit d6111c6 has been approved by |
|
obviously, having test for new option would be good, but not blocking on it now |
|
☀️ Test successful - status-jenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option sets clean_requirements_on_remove to false from commandline. The
cleaning is pretty strong behavior that is handy to be easily be switched off.
https://bugzilla.redhat.com/show_bug.cgi?id=1361424