Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure everything behaves correctly during the branching window #7

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

FrostyX
Copy link
Member

@FrostyX FrostyX commented Feb 14, 2024

@FrostyX
Copy link
Member Author

FrostyX commented Feb 14, 2024

What do you think @xsuchy?

# During the window from branching to the final release, things can get
# weird. Bodhi can be lying to us. For example, F40 was branched yesterday,
# therefore Rawhide is F41 now. However bodhi says that Fedora 40 branch is
# `rawhide` and F41 branch is `f41`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you adjust f41 to have rawhide branch? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review @mfocko,
That is done in the line just above this comment.
Here I am trying to change F40 which has incorrectly set its branch (by bodhi) to rawhide instead of f40.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can “blame” the diff view… It shows just the branch, not the list and index :/

Copy link
Member

@praiskup praiskup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FrostyX FrostyX merged commit c40b192 into rpm-software-management:main Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants