Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedora-all alias does not work #491

Closed
xsuchy opened this issue Feb 14, 2024 · 3 comments
Closed

fedora-all alias does not work #491

xsuchy opened this issue Feb 14, 2024 · 3 comments
Labels
effort/low Can be done in few hours gain/high Significantly moves the project forward

Comments

@xsuchy
Copy link
Member

xsuchy commented Feb 14, 2024

I changed my releasers.conf to

[fedora-git]
releaser = tito.release.FedoraGitReleaser
# from top to down
branches = fedora-all epel-all

Previously, I have there branches enumerated.

But now I got:

$ tito release fedora-git
...
Would you like to edit this commit message? [y/n] n
Proceeding with commit.
fedpkg push
Submitting build: fedpkg build --nowait  
Created task: 113477647
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=113477647
Merging branch: 'rawhide' -> 'f38'
git push origin f38:f38
Submitting build: fedpkg build --nowait  
Created task: 113477654
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=113477654
Merging branch: 'rawhide' -> 'f39'
git push origin f39:f39
Submitting build: fedpkg build --nowait  
Created task: 113477669
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=113477669
Merging branch: 'rawhide' -> 'f41'
ERROR: Error running command: fedpkg switch-branch f41

Status code: 1

Command output: Could not execute switch_branch: Unknown remote branch origin/f41

Traceback (most recent call last):
  File "/usr/bin/tito", line 33, in <module>
    sys.exit(load_entry_point('tito==0.6.25', 'console_scripts', 'tito')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/tito/cli.py", line 944, in main
    CLI().main(sys.argv[1:])
  File "/usr/lib/python3.12/site-packages/tito/cli.py", line 210, in main
    return module.main(argv)
           ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/tito/cli.py", line 650, in main
    releaser.release(dry_run=self.options.dry_run,
  File "/usr/lib/python3.12/site-packages/tito/release/distgit.py", line 93, in release
    self._git_release()
  File "/usr/lib/python3.12/site-packages/tito/release/distgit.py", line 152, in _git_release
    self._git_user_confirm_commit(self.package_workdir)
  File "/usr/lib/python3.12/site-packages/tito/release/distgit.py", line 290, in _git_user_confirm_commit
    run_command("%s switch-branch %s" % (self.cli_tool, branch))
  File "/usr/lib/python3.12/site-packages/tito/common.py", line 305, in run_command
    raise RunCommandException(command, status, output)
tito.exception.RunCommandException: Error running command: fedpkg switch-branch f41
@xsuchy
Copy link
Member Author

xsuchy commented Feb 14, 2024

Seems it tries to build to 41 instead of 40 which is branched now.

@FrostyX FrostyX added effort/low Can be done in few hours gain/high Significantly moves the project forward labels Feb 14, 2024
@FrostyX
Copy link
Member

FrostyX commented Feb 14, 2024

As expected, the bug is in the fedora-distro-aliases package:

In [1]: from fedora_distro_aliases import get_distro_aliases
In [2]: aliases = get_distro_aliases()

In [3]: [x.namever for x in aliases["fedora-all"]]
Out[3]: ['fedora-38', 'fedora-39', 'fedora-40', 'fedora-rawhide']

In [4]: [x.branch for x in aliases["fedora-all"]]
Out[4]: ['f38', 'f39', 'rawhide', 'f41']

See the strange difference between branches and namevers.

@FrostyX
Copy link
Member

FrostyX commented Feb 24, 2024

I am going to close the issue now. It is fixed in the fedora-distro-aliases package
https://github.com/rpm-software-management/fedora-distro-aliases/releases/tag/fedora-distro-aliases-1.3-1
We are just waiting till the bodhi updates drop into stable.

@FrostyX FrostyX closed this as completed Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/low Can be done in few hours gain/high Significantly moves the project forward
Projects
None yet
Development

No branches or pull requests

2 participants