Query realdep and index improvement #696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still think returning an error is much better than silently skipping it. |
jrohel
requested changes
Mar 13, 2019
libdnf/sack/query.cpp
Outdated
| if (reldeplist->count()) { | ||
| pImpl->filters.push_back(Filter(keyname, HY_EQ, reldeplist)); | ||
| } else { | ||
| addFilter(HY_PKG_EMPTY, HY_EQ, 1); |
There was a problem hiding this comment.
Why not pImpl->filters.push_back(Filter(HY_PKG_EMPTY, HY_EQ, 1)); ?
If provided string to a query is incorrectly formatted, the query should be empty. https://bugzilla.redhat.com/show_bug.cgi?id=1687135
The formal implementation results in Segmentation fault (core dumped).
jrohel
approved these changes
Mar 13, 2019
|
@ignatenkobrain Yes, hiding errors can bring problems later. |
|
📌 Commit ae2f46a has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 13, 2019
The formal implementation results in Segmentation fault (core dumped). Closes: #696 Approved by: jrohel
|
☀️ Test successful - status-papr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.