Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmpfs keep_mounted breaks mockchain #479

Closed
praiskup opened this issue Feb 18, 2020 · 0 comments · Fixed by #507
Closed

tmpfs keep_mounted breaks mockchain #479

praiskup opened this issue Feb 18, 2020 · 0 comments · Fixed by #507
Labels
bug

Comments

@praiskup
Copy link
Member 

  File "/usr/libexec/mock/mock", line 1026, in <module>
    exitStatus = main()
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
  File "/usr/libexec/mock/mock", line 805, in main
    result = run_command(options, args, config_opts, commands, buildroot, state)
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
  File "/usr/libexec/mock/mock", line 845, in run_command
    result = commands.chain(args, options, buildroot)
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.7/site-packages/mockbuild/backend.py", line 475, in chain
    do_rebuild(self.config, self, buildroot, options, [pkg])
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.7/site-packages/mockbuild/rebuild.py", line 84, in do_rebuild
    post=post_build, clean=clean)
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.7/site-packages/mockbuild/rebuild.py", line 23, in rebuild_generic
    commands.clean()
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.7/site-packages/mockbuild/backend.py", line 93, in clean
    self.buildroot.delete()
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.7/site-packages/mockbuild/buildroot.py", line 749, in delete
    util.rmtree(self.basedir, selinux=self.selinux)
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.7/site-packages/mockbuild/util.py", line 241, in rmtree
    rmtree(fullname, selinux=selinux, exclude=exclude)
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.7/site-packages/mockbuild/util.py", line 250, in rmtree
    os.rmdir(path)
OSError: [Errno 16] Device or resource busy: '/var/lib/mock/epel-8-x86_64/root'
@praiskup praiskup added the bug label Feb 18, 2020
praiskup added a commit to praiskup/mock that referenced this issue Mar 3, 2020
@praiskup
mockchain: don't run buildroot.finalize() for each package
4e8fd46 
That invalidates mount points, and probably cleans the buildroot too
much without reason.  There's automatic buildroot.clean() call before
each package anyways.

Fixes: rpm-software-management#479
@praiskup praiskup mentioned this issue Mar 3, 2020
Merged
praiskup added a commit that referenced this issue Mar 4, 2020
@praiskup
mockchain: don't run buildroot.finalize() for each package
3513959 
That invalidates mount points, and probably cleans the buildroot too
much without reason.  There's automatic buildroot.clean() call before
each package anyways.

Fixes: #479
praiskup added a commit to praiskup/mock that referenced this issue Mar 5, 2020
@praiskup
tests: add 13-mockchain-gen-br.tst
18f54c5 
Test that mockchain works, with tmpfs plugin ON (keep_mounted=True),
nocache plugin ON, and dynamic buildrequires package.

Relates: rpm-software-management#482, rpm-software-management#512, rpm-software-management#479
praiskup added a commit to praiskup/mock that referenced this issue Mar 5, 2020
@praiskup
tests: add 13-mockchain-gen-br.tst
eb8a30b 
Test that mockchain works, with tmpfs plugin ON (keep_mounted=True),
nocache plugin ON, and dynamic buildrequires package.

Relates: rpm-software-management#482, rpm-software-management#512, rpm-software-management#479
praiskup added a commit that referenced this issue Mar 5, 2020
@praiskup
tests: add 13-mockchain-gen-br.tst
0772468 
Test that mockchain works, with tmpfs plugin ON (keep_mounted=True),
nocache plugin ON, and dynamic buildrequires package.

Relates: #482, #512, #479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mockchain: don't run buildroot.finalize() for each package praiskup/mock
1 participant
@praiskup